[GitHub] [hbase] javierluca commented on a change in pull request #3054: HBASE-25594 Make easier to use graceful_stop on localhost mode

[GitBox <gi...@apache.org>]

javierluca commented on a change in pull request #3054:
URL: https://github.com/apache/hbase/pull/3054#discussion_r597387532



##########
File path: bin/graceful_stop.sh
##########
@@ -108,6 +108,10 @@ localhostname=`/bin/hostname -f`
 if [ "$localhostname" == "$hostname" ]; then
   local=true
 fi
+if [ "$localhostname" == "$hostname" ] || [ "$hostname" == "localhost" ]; then
+  local=true
+  hostname=$localhostname

Review comment:
       > Do we have to repeat the 'if [ "$localhostname" == "$hostname" ] ...' and the setting of local = true
   
   Ah no, that is my mistake. Sorry about that, we should remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org