You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Deives Michellis (JIRA)" <ji...@apache.org> on 2012/05/11 16:32:50 UTC
[jira] [Created] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Deives Michellis created AMQ-3836:
-------------------------------------
Summary: STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
Key: AMQ-3836
URL: https://issues.apache.org/jira/browse/AMQ-3836
Project: ActiveMQ
Issue Type: Bug
Components: stomp
Affects Versions: 5.6.0
Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
Reporter: Deives Michellis
Destination specification on STOMP using activemq 5.6.0 is broken.
Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286811#comment-13286811 ]
Timothy Bish commented on AMQ-3836:
-----------------------------------
Agreed the spec was a bit vague in this regard. In 5.6 we removed the header trimming in order to not discard spaces that a client had intentionally placed there. It might be good to at least do a test on a trimmed destination value before assuming its a queue and getting into this scenario.
> STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
> -------------------------------------------------------------------
>
> Key: AMQ-3836
> URL: https://issues.apache.org/jira/browse/AMQ-3836
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.6.0
> Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
> Reporter: Deives Michellis
> Attachments: firsttony.php
>
>
> Destination specification on STOMP using activemq 5.6.0 is broken.
> Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
> For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
> Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish resolved AMQ-3836.
-------------------------------
Resolution: Fixed
Fix Version/s: 5.7.0
Assignee: Timothy Bish
Fixed to attempt to find the right destination with spaces padding trimmed before falling back to the configured fallback handler. Also updated the Stomp PHP client to not pad headers.
> STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
> -------------------------------------------------------------------
>
> Key: AMQ-3836
> URL: https://issues.apache.org/jira/browse/AMQ-3836
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.6.0
> Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
> Reporter: Deives Michellis
> Assignee: Timothy Bish
> Fix For: 5.7.0
>
> Attachments: firsttony.php
>
>
> Destination specification on STOMP using activemq 5.6.0 is broken.
> Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
> For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
> Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Posted by "Alan Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286191#comment-13286191 ]
Alan Hudson commented on AMQ-3836:
----------------------------------
The issue is with STOMP clients that put spaces after values as in destination: /topic/test
The convert destination method in LegacyFrameTranslator does a startsWith("/topic") to detect topics.
The fuse stomp php client puts a space on items. My read of the stomp spec shows examples without it. But it doesn't really make it clear. We're looking around at a few other clients to see what they do.
If its common of clients then it might make sense to deal with it on the server. The other php stomp client does not put spaces in its values.
I can easily make a junit test for this case if you want it, but I kinda expect this will be labeled under "client error" or maybe incomplete spec language(my pet peeve).
> STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
> -------------------------------------------------------------------
>
> Key: AMQ-3836
> URL: https://issues.apache.org/jira/browse/AMQ-3836
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.6.0
> Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
> Reporter: Deives Michellis
> Attachments: firsttony.php
>
>
> Destination specification on STOMP using activemq 5.6.0 is broken.
> Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
> For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
> Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274623#comment-13274623 ]
Timothy Bish commented on AMQ-3836:
-----------------------------------
You'll need to provide a test case, can't reproduce this so far.
> STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
> -------------------------------------------------------------------
>
> Key: AMQ-3836
> URL: https://issues.apache.org/jira/browse/AMQ-3836
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.6.0
> Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
> Reporter: Deives Michellis
>
> Destination specification on STOMP using activemq 5.6.0 is broken.
> Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
> For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
> Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Posted by "Alan Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285859#comment-13285859 ]
Alan Hudson commented on AMQ-3836:
----------------------------------
I'm seeing the same problem. We're using a modified first.php from the fuse php client. I'll clean it up and attach it.
> STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
> -------------------------------------------------------------------
>
> Key: AMQ-3836
> URL: https://issues.apache.org/jira/browse/AMQ-3836
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.6.0
> Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
> Reporter: Deives Michellis
>
> Destination specification on STOMP using activemq 5.6.0 is broken.
> Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
> For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
> Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Posted by "Alan Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286803#comment-13286803 ]
Alan Hudson commented on AMQ-3836:
----------------------------------
I found this language in the STOMP specification under Value Encoding:
The STOMP 1.0 specification included many example frames with padding in the headers and many servers and clients were implemented to trim or pad header values. This causes problems if applications want to send headers that SHOULD not get trimmed. In STOMP 1.1, clients and servers MUST never trim or pad headers with spaces.
So I believe we should not do any space removal. I think this ticket can be closed.
> STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
> -------------------------------------------------------------------
>
> Key: AMQ-3836
> URL: https://issues.apache.org/jira/browse/AMQ-3836
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.6.0
> Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
> Reporter: Deives Michellis
> Attachments: firsttony.php
>
>
> Destination specification on STOMP using activemq 5.6.0 is broken.
> Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
> For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
> Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Posted by "Deives Michellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273309#comment-13273309 ]
Deives Michellis commented on AMQ-3836:
---------------------------------------
I have absolutely no idea how to do that. I am not a java guy, sorry
> STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
> -------------------------------------------------------------------
>
> Key: AMQ-3836
> URL: https://issues.apache.org/jira/browse/AMQ-3836
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.6.0
> Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
> Reporter: Deives Michellis
>
> Destination specification on STOMP using activemq 5.6.0 is broken.
> Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
> For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
> Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273304#comment-13273304 ]
Timothy Bish commented on AMQ-3836:
-----------------------------------
Recommend you create a JUnit test case to demonstrate your issue.
> STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
> -------------------------------------------------------------------
>
> Key: AMQ-3836
> URL: https://issues.apache.org/jira/browse/AMQ-3836
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.6.0
> Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
> Reporter: Deives Michellis
>
> Destination specification on STOMP using activemq 5.6.0 is broken.
> Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
> For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
> Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Posted by "Alan Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285878#comment-13285878 ]
Alan Hudson commented on AMQ-3836:
----------------------------------
I will. Just getting my head around the problem, so far we're learning stomp from the php client.
> STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
> -------------------------------------------------------------------
>
> Key: AMQ-3836
> URL: https://issues.apache.org/jira/browse/AMQ-3836
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.6.0
> Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
> Reporter: Deives Michellis
> Attachments: firsttony.php
>
>
> Destination specification on STOMP using activemq 5.6.0 is broken.
> Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
> For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
> Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273321#comment-13273321 ]
Timothy Bish commented on AMQ-3836:
-----------------------------------
StompTest.java in our unit tests has plenty of examples, barring that please create a test case using the client you are currently using.
> STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
> -------------------------------------------------------------------
>
> Key: AMQ-3836
> URL: https://issues.apache.org/jira/browse/AMQ-3836
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.6.0
> Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
> Reporter: Deives Michellis
>
> Destination specification on STOMP using activemq 5.6.0 is broken.
> Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
> For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
> Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285875#comment-13285875 ]
Timothy Bish commented on AMQ-3836:
-----------------------------------
Why not try and reproduce it with a JUnit test? There's already a large number of them in StompTest.java to work from.
> STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
> -------------------------------------------------------------------
>
> Key: AMQ-3836
> URL: https://issues.apache.org/jira/browse/AMQ-3836
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.6.0
> Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
> Reporter: Deives Michellis
> Attachments: firsttony.php
>
>
> Destination specification on STOMP using activemq 5.6.0 is broken.
> Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
> For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
> Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-3836) STOMP 1.0 protocol (SUBSCRIBE
destination) broken on ActiveMQ 5.6.0
Posted by "Alan Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Hudson updated AMQ-3836:
-----------------------------
Attachment: firsttony.php
modified first.php from fuse stomp php client. the result on 5.5.1 comes back as:
Notice the destination has a /queue on it in 5.6.0 We checked the STOMP frame and its not coming from the client.
In 5.5.1 we get this result:
Received headers
s_scale => 0.001
message-id => ID:tony-desktop-53600-1338396365864-2:12:-1:1:1
d_serviceName => ModelUpload
destination => /topic/testtopic
timestamp => 1338399414341
s_modelID => 123456
expires => 0
priority => 4
In 5.6.0 we get this result:
Received headers
s_scale => 0.001
message-id => ID:maker-55961-1338400788753-2:2:-1:1:1
d_serviceName => ModelUpload
destination => /queue//topic/testtopic
timestamp => 1338401617112
s_modelID => 123456
expires => 0
priority => 4
Here is the frame that was sent:
SEND
d_serviceName: ModelUpload
s_modelID: 123456
s_scale: 0.001
destination: /topic/testtopic
test
---
I suspect its something in the FrameTranslator, digging in there.
> STOMP 1.0 protocol (SUBSCRIBE destination) broken on ActiveMQ 5.6.0
> -------------------------------------------------------------------
>
> Key: AMQ-3836
> URL: https://issues.apache.org/jira/browse/AMQ-3836
> Project: ActiveMQ
> Issue Type: Bug
> Components: stomp
> Affects Versions: 5.6.0
> Environment: Centos 5 running Apache ActiveMQ 5.6.0, jre-1.6.0_20-fcs
> Reporter: Deives Michellis
> Attachments: firsttony.php
>
>
> Destination specification on STOMP using activemq 5.6.0 is broken.
> Before 5.6.0, you had to specify "/queue/my_queue". Now, activemq automatically includes a "/queue/" on destination name, whether needed or not.
> For instance, sending messages to "/queue/nagios-events" works. Subscribing to "/queue/nagios-events" creates an additional queue named "/queue/queue/nagios-events".
> Message sending is also affected, although it accepts both "/queue/nagios-events" and "nagios-events"
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira