[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #7215: Log config reload: use new config for initialization

[GitBox <gi...@apache.org>]

SolidWallOfCode commented on a change in pull request #7215:
URL: https://github.com/apache/trafficserver/pull/7215#discussion_r496132235



##########
File path: proxy/logging/LogBuffer.cc
##########
@@ -111,8 +111,8 @@ LogBuffer::LogBuffer(LogObject *owner, size_t size, size_t buf_align, size_t wri
   //
   int64_t alloc_size = size + buf_align;
 
-  if (alloc_size <= BUFFER_SIZE_FOR_INDEX(Log::config->logbuffer_max_iobuf_index)) {
-    m_buffer_fast_allocator_size = buffer_size_to_index(alloc_size, Log::config->logbuffer_max_iobuf_index);
+  if (alloc_size <= BUFFER_SIZE_FOR_INDEX(cfg->logbuffer_max_iobuf_index)) {

Review comment:
       Is there any locking around `cfg`? Can it change between line 114 and 115?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org