You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by nabarun nag <nn...@pivotal.io> on 2016/10/24 16:33:57 UTC

Review Request 53026: GEODE-502: Startup timeout increased to 2min in DUnitLauncher

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53026/
-----------------------------------------------------------

Review request for geode and Dan Smith.


Repository: geode


Description
-------

* While creating VMs for the DUnit tests sometimes GC may kick in
* But the test framework requires the VMs to be ready within 30 seconds.
* So we have increased the timeout to 2min to account for the time consumed by GC
* This is to handle errors in CI running in slower machines.


Diffs
-----

  geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java 6618d2a 

Diff: https://reviews.apache.org/r/53026/diff/


Testing
-------

precheck


Thanks,

nabarun nag


Re: Review Request 53026: GEODE-502: Startup timeout increased to 2min in DUnitLauncher

Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53026/#review153706
-----------------------------------------------------------


Ship it!




Ship It!

- Dan Smith


On Oct. 24, 2016, 4:33 p.m., nabarun nag wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53026/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2016, 4:33 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> * While creating VMs for the DUnit tests sometimes GC may kick in
> * But the test framework requires the VMs to be ready within 30 seconds.
> * So we have increased the timeout to 2min to account for the time consumed by GC
> * This is to handle errors in CI running in slower machines.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java 6618d2a 
> 
> Diff: https://reviews.apache.org/r/53026/diff/
> 
> 
> Testing
> -------
> 
> precheck
> 
> 
> Thanks,
> 
> nabarun nag
> 
>