You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/07/01 02:21:09 UTC
Review Request 23187: Fixed a regression in ExecutorInfoChecker to allow an
executor with the same id but different executor info as long as it is on a
different slave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23187/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
Bugs: MESOS-1555
https://issues.apache.org/jira/browse/MESOS-1555
Repository: mesos-git
Description
-------
See summary and bug for details.
Diffs
-----
src/master/master.cpp 474014b24982449f2f64c2e8d835c25a28cbcbb8
src/tests/master_authorization_tests.cpp 478041cdea533e548ca92c4b8e8c793554855969
src/tests/resource_offers_tests.cpp 3ec688abea1557a17526589b31f58ad6e53abec4
Diff: https://reviews.apache.org/r/23187/diff/
Testing
-------
make check
make GTEST_FILTER="*PendingExecutorInfoDiffersOnDifferentSlaves*" GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE
Thanks,
Vinod Kone
Re: Review Request 23187: Fixed a regression in ExecutorInfoChecker to allow
an executor with the same id but different executor info as long as it is
on a different slave.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23187/#review47109
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On June 30, 2014, 5:21 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23187/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 5:21 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
>
>
> Bugs: MESOS-1555
> https://issues.apache.org/jira/browse/MESOS-1555
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and bug for details.
>
>
> Diffs
> -----
>
> src/master/master.cpp 474014b24982449f2f64c2e8d835c25a28cbcbb8
> src/tests/master_authorization_tests.cpp 478041cdea533e548ca92c4b8e8c793554855969
> src/tests/resource_offers_tests.cpp 3ec688abea1557a17526589b31f58ad6e53abec4
>
> Diff: https://reviews.apache.org/r/23187/diff/
>
>
> Testing
> -------
>
> make check
>
> make GTEST_FILTER="*PendingExecutorInfoDiffersOnDifferentSlaves*" GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 23187: Fixed a regression in ExecutorInfoChecker to allow
an executor with the same id but different executor info as long as it is
on a different slave.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23187/#review47076
-----------------------------------------------------------
Ship it!
LGTM
- Jie Yu
On July 1, 2014, 12:21 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23187/
> -----------------------------------------------------------
>
> (Updated July 1, 2014, 12:21 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
>
>
> Bugs: MESOS-1555
> https://issues.apache.org/jira/browse/MESOS-1555
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and bug for details.
>
>
> Diffs
> -----
>
> src/master/master.cpp 474014b24982449f2f64c2e8d835c25a28cbcbb8
> src/tests/master_authorization_tests.cpp 478041cdea533e548ca92c4b8e8c793554855969
> src/tests/resource_offers_tests.cpp 3ec688abea1557a17526589b31f58ad6e53abec4
>
> Diff: https://reviews.apache.org/r/23187/diff/
>
>
> Testing
> -------
>
> make check
>
> make GTEST_FILTER="*PendingExecutorInfoDiffersOnDifferentSlaves*" GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 23187: Fixed a regression in ExecutorInfoChecker to allow
an executor with the same id but different executor info as long as it is
on a different slave.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23187/#review47035
-----------------------------------------------------------
Patch looks great!
Reviews applied: [23187]
All tests passed.
- Mesos ReviewBot
On July 1, 2014, 12:21 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23187/
> -----------------------------------------------------------
>
> (Updated July 1, 2014, 12:21 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
>
>
> Bugs: MESOS-1555
> https://issues.apache.org/jira/browse/MESOS-1555
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary and bug for details.
>
>
> Diffs
> -----
>
> src/master/master.cpp 474014b24982449f2f64c2e8d835c25a28cbcbb8
> src/tests/master_authorization_tests.cpp 478041cdea533e548ca92c4b8e8c793554855969
> src/tests/resource_offers_tests.cpp 3ec688abea1557a17526589b31f58ad6e53abec4
>
> Diff: https://reviews.apache.org/r/23187/diff/
>
>
> Testing
> -------
>
> make check
>
> make GTEST_FILTER="*PendingExecutorInfoDiffersOnDifferentSlaves*" GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE
>
>
> Thanks,
>
> Vinod Kone
>
>