You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/10/05 17:38:02 UTC

[GitHub] [commons-lang] verhas commented on issue #462: General Code Cleanup

verhas commented on issue #462: General Code Cleanup
URL: https://github.com/apache/commons-lang/pull/462#issuecomment-538671729
 
 
   "Coverage decreased (-0.2%) to 94.965% when pulling 5e197f3 on verhas:CLEANUP into 4f3d3b4 on apache:master."
   
   This simply shows that the tested code became shorter. Yes, I also deleted a test that actually did nothing, it was asserting that a returned boolean value is either true or false (what else?).
   
   So if anyone takes the effort to review this pull request then do not blindly toss it aside because of the coverage in terms of percentage (which is not a good measure really for the very reason demonstrated here) decreased.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services