You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Atharv625 (via GitHub)" <gi...@apache.org> on 2025/04/26 09:31:22 UTC
[PR] Enhance Tableau Sensor Logs to Include Friendly Object Names [airflow]
Atharv625 opened a new pull request, #49810:
URL: https://github.com/apache/airflow/pull/49810
This PR introduces an improvement to the TableauHook by enhancing its logging functionality. It modifies the job status logging to include the object type (e.g., Workbook, Datasource) and object name (friendly name) along with the job's finish code. This modification makes it easier for users to identify which specific Tableau object a job is associated with, improving visibility and traceability, particularly in environments with many concurrent jobs.
The changes are primarily aimed at improving user experience and debugging efficiency, especially when handling multiple Tableau jobs of different types.
Changes:
Enhanced Job Logging:
The job’s logs now show the type and name of the associated Tableau resource (e.g., Workbook, Datasource) alongside the job’s finish code and ID.
Example of previous log:
pgsql
Copy
Edit
[2025-04-23, 17:24:23 UTC] {tableau.py:73} INFO - Current finishCode is SUCCESS (0)
New log output with object type and name:
pgsql
Copy
Edit
[2025-04-23, 17:24:23 UTC] {tableau.py:73} INFO - Current finishCode is SUCCESS (0) for Workbook 'Sales Report'
Job Details Fetching:
Introduced a helper method get_job() that returns job details in a structured format, including resource type, object name, object ID, and finish code.
Job State Wait Function:
The wait_for_state() method waits until the job reaches the target state (e.g., SUCCESS, ERROR, CANCELED) and provides more informative logs during the process.
#49671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enhance Tableau Sensor Logs to Include Friendly Object Names [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #49810:
URL: https://github.com/apache/airflow/pull/49810#discussion_r2071122591
##########
providers/tableau/src/airflow/providers/tableau/hooks/tableau.py:
##########
@@ -1,19 +1,20 @@
# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
+# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
+# regarding copyright ownership. The ASF licenses this file
Review Comment:
Why did you change the licence header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enhance Tableau Sensor Logs to Include Friendly Object Names [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #49810: Enhance Tableau Sensor Logs to Include Friendly Object Names
URL: https://github.com/apache/airflow/pull/49810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enhance Tableau Sensor Logs to Include Friendly Object Names [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49810:
URL: https://github.com/apache/airflow/pull/49810#issuecomment-2978536129
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org