You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "Kusuma04-dev (via GitHub)" <gi...@apache.org> on 2026/05/05 06:03:32 UTC
[PR] kie-issue#118: Upgrade React from v17 to v18 on kie-tools [incubator-kie-tools]
Kusuma04-dev opened a new pull request, #3559:
URL: https://github.com/apache/incubator-kie-tools/pull/3559
closes https://github.com/apache/incubator-kie-issues/issues/118,
upgraded react from v17 to v18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#118: Upgrade React from v17 to v18 on kie-tools [incubator-kie-tools]
Posted by "ljmotta (via GitHub)" <gi...@apache.org>.
ljmotta commented on code in PR #3559:
URL: https://github.com/apache/incubator-kie-tools/pull/3559#discussion_r3343795158
##########
packages/pmml-editor/src/editor/PMMLEditor.tsx:
##########
@@ -121,7 +122,10 @@ export class PMMLEditor extends React.Component<Props, State> {
}
public componentDidMount(): void {
- this.props.ready();
+ // Use flushSync to ensure the editor is fully mounted before signaling ready
+ flushSync(() => {
+ this.props.ready();
+ });
Review Comment:
This flushSync is required so we are sure the editor is ready before redering it. We had a problem with PMML Editor on `online-editor` where PMML would be never "ready".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#118: Upgrade React from v17 to v18 on kie-tools [incubator-kie-tools]
Posted by "ljmotta (via GitHub)" <gi...@apache.org>.
ljmotta commented on code in PR #3559:
URL: https://github.com/apache/incubator-kie-tools/pull/3559#discussion_r3343797462
##########
packages/online-editor/tests-e2e/createFiles/newFile.spec.ts:
##########
@@ -48,11 +48,13 @@ test.describe("New file", () => {
await expect(page).toHaveScreenshot("new-file-dmn.png");
});
- test("should create a new PMML file", async ({ page, kieSandbox }) => {
+ test("should create a new PMML file", async ({ page, kieSandbox, browserName }) => {
await page.getByRole("button", { name: "New Scorecard" }).click();
await expect(page.getByRole("button", { name: "Scorecard Untitled" })).toBeAttached();
await expect(page.getByRole("button", { name: "Scorecard Untitled" })).toContainText("Untitled");
- await expect(kieSandbox.getEditor().getByRole("button", { name: "Set Data Dictionary" })).toBeAttached();
+ await expect(kieSandbox.getEditor().getByRole("button", { name: "Set Data Dictionary" })).toBeAttached({
+ timeout: 90000,
+ });
Review Comment:
I believe this can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#118: Upgrade React from v17 to v18 on kie-tools [incubator-kie-tools]
Posted by "SoniyaAbraham89 (via GitHub)" <gi...@apache.org>.
SoniyaAbraham89 commented on code in PR #3559:
URL: https://github.com/apache/incubator-kie-tools/pull/3559#discussion_r3340729706
##########
packages/bpmn-editor/tests-e2e/__fixtures__/propertiesPanel/propertiesPanelBase.ts:
##########
@@ -62,4 +62,11 @@ export abstract class PropertiesPanelBase {
public async isOpen(): Promise<boolean> {
return await this.panel().isVisible();
}
+
+ public async fillCombobox(value: string, index: number = 0): Promise<void> {
Review Comment:
31/.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#118: Upgrade React from v17 to v18 on kie-tools [incubator-kie-tools]
Posted by "thiagoelg (via GitHub)" <gi...@apache.org>.
thiagoelg commented on code in PR #3559:
URL: https://github.com/apache/incubator-kie-tools/pull/3559#discussion_r3343726133
##########
packages/online-editor/tests-e2e/createFiles/newFile.spec.ts:
##########
@@ -48,11 +48,13 @@ test.describe("New file", () => {
await expect(page).toHaveScreenshot("new-file-dmn.png");
});
- test("should create a new PMML file", async ({ page, kieSandbox }) => {
+ test("should create a new PMML file", async ({ page, kieSandbox, browserName }) => {
await page.getByRole("button", { name: "New Scorecard" }).click();
await expect(page.getByRole("button", { name: "Scorecard Untitled" })).toBeAttached();
await expect(page.getByRole("button", { name: "Scorecard Untitled" })).toContainText("Untitled");
- await expect(kieSandbox.getEditor().getByRole("button", { name: "Set Data Dictionary" })).toBeAttached();
+ await expect(kieSandbox.getEditor().getByRole("button", { name: "Set Data Dictionary" })).toBeAttached({
+ timeout: 90000,
+ });
Review Comment:
Is this timeout really needed? Our playwright-base config already defines a global timeout.
##########
packages/pmml-editor/src/editor/PMMLEditor.tsx:
##########
@@ -121,7 +122,10 @@ export class PMMLEditor extends React.Component<Props, State> {
}
public componentDidMount(): void {
- this.props.ready();
+ // Use flushSync to ensure the editor is fully mounted before signaling ready
+ flushSync(() => {
+ this.props.ready();
+ });
Review Comment:
Is this flushSync necessary?
##########
packages/playwright-base/env/index.js:
##########
@@ -51,7 +51,7 @@ module.exports = composeEnv([require("@kie-tools/root-env/env")], {
"The threshold of the maximum pixel difference on screenshot comparisons (percentage in decimal form)",
},
PLAYWRIGHT_BASE__retries: {
- default: "0",
+ default: "2",
Review Comment:
Should we revert to 0? Given the number of flaky tests we have, I would leave it a 2, but what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#118: Upgrade React from v17 to v18 on kie-tools [incubator-kie-tools]
Posted by "ljmotta (via GitHub)" <gi...@apache.org>.
ljmotta commented on code in PR #3559:
URL: https://github.com/apache/incubator-kie-tools/pull/3559#discussion_r3343782533
##########
packages/playwright-base/env/index.js:
##########
@@ -51,7 +51,7 @@ module.exports = composeEnv([require("@kie-tools/root-env/env")], {
"The threshold of the maximum pixel difference on screenshot comparisons (percentage in decimal form)",
},
PLAYWRIGHT_BASE__retries: {
- default: "0",
+ default: "2",
Review Comment:
I believe 2 is a good number to run the test suite on the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#118: Upgrade React from v17 to v18 on kie-tools [incubator-kie-tools]
Posted by "SoniyaAbraham89 (via GitHub)" <gi...@apache.org>.
SoniyaAbraham89 commented on code in PR #3559:
URL: https://github.com/apache/incubator-kie-tools/pull/3559#discussion_r3340729706
##########
packages/bpmn-editor/tests-e2e/__fixtures__/propertiesPanel/propertiesPanelBase.ts:
##########
@@ -62,4 +62,11 @@ export abstract class PropertiesPanelBase {
public async isOpen(): Promise<boolean> {
return await this.panel().isVisible();
}
+
+ public async fillCombobox(value: string, index: number = 0): Promise<void> {
Review Comment:
31/.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#118: Upgrade React from v17 to v18 on kie-tools [incubator-kie-tools]
Posted by "Kusuma04-dev (via GitHub)" <gi...@apache.org>.
Kusuma04-dev commented on PR #3559:
URL: https://github.com/apache/incubator-kie-tools/pull/3559#issuecomment-4466786963
Thanks for the review @kbowers-ibm , Yes , i have fixed the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#118: Upgrade React from v17 to v18 on kie-tools [incubator-kie-tools]
Posted by "ljmotta (via GitHub)" <gi...@apache.org>.
ljmotta merged PR #3559:
URL: https://github.com/apache/incubator-kie-tools/pull/3559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org