You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/05/30 19:41:30 UTC
[GitHub] eolivelli commented on a change in pull request #1457: [table
service] cleanup : cleanup protobuf definitions
eolivelli commented on a change in pull request #1457: [table service] cleanup : cleanup protobuf definitions
URL: https://github.com/apache/bookkeeper/pull/1457#discussion_r191897652
##########
File path: stream/proto/src/main/proto/stream.proto
##########
@@ -85,6 +85,15 @@ message ParentRangesList {
// Stream
//
+// since stream and table are similar and exchangable,
+// from the beginning, we shared the metadata management
+// between streams and tables and distinguish them using
+// a flag that recorded in metadata.
+enum StreamType {
Review comment:
Streamtype = table seems a bit weird.
What about something like StorageMode, DataModel....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services