[jira] [Comment Edited] (KARAF-2558) Unit Tests in error when building from trunk on Windows platform

["Satya Deep Maheshwari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818119#comment-13818119 ] 

Satya Deep Maheshwari edited comment on KARAF-2558 at 11/10/13 12:40 PM:
-------------------------------------------------------------------------

Attaching patch for review.

Identified a couple of issues:
1. I see that its just the karaf.log file in the data/log folder which is locked in between tests which prevents the deletion of data folder. Not sure on how to prevent that locking. As a workaround fix, generate a unique folder name so that it does not conflict with data folders of other UTs.

2.In PropertiesLoginModuleTest , fixed the path to be platform agnostic instead of using '/' path separator which does not work on Windows platform.


was (Author: satyadeep):
Attaching patch for review.

Identified a couple of issues:
1. In org.apache.karaf.main.MainStartTest , used junit TemporaryFolder which is ensured to be deleted after test completion instead of an earlier folder which wasn't getting deleted on windows platform because it was shared across test cases and locked for deletion.

2.In PropertiesLoginModuleTest , fixed the path to be platform agnostic instead of using '/' path separator which does not work on Windows platform.

> Unit Tests in error when building from trunk  on Windows platform
> -----------------------------------------------------------------
>
>                 Key: KARAF-2558
>                 URL: https://issues.apache.org/jira/browse/KARAF-2558
>             Project: Karaf
>          Issue Type: Bug
>    Affects Versions: 3.0.0.RC1
>            Reporter: Satya Deep Maheshwari
>              Labels: build
>         Attachments: KARAF-2558.patch
>
>
> Some UTs are failing when building from the trunk on Windows platform. The failing tests are:
>  testAutoStart(org.apache.karaf.main.MainStartTest): Unable to delete file: C:\svn\svn.apache.org\karaf\main\target\test-classes\test-karaf-home\data\log\karaf.log 
>   testStopWithTimeout(org.apache.karaf.main.MainStartTest): Unable to delete file: C:\svn\svn.apache.org\karaf\main\target\test-classes\test-karaf-home\data\log\karaf.log 



--
This message was sent by Atlassian JIRA
(v6.1#6144)