You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "bradh352 (via GitHub)" <gi...@apache.org> on 2025/10/29 15:01:47 UTC

[PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

bradh352 opened a new pull request, #11932:
URL: https://github.com/apache/cloudstack/pull/11932

   ### Description
   
   As per #11930 KVM's memory ballooning does not auto-inflate and auto-deflate without the Free Page Reporting and autodeflate attributes on the memballoon configuration.
   
   This is a change similar to OpenStack's NOVA:
   https://github.com/openstack/nova/commit/cd401c5c1b5dcba739d69875795828e1be1d726b
   
   Basically if memballooning is enabled for KVM, these features are also always enabled.  Having memory ballooning on in cloudstack otherwise does nothing as there is no tooling to inflate or deflate the balloon.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] Build/CI
   - [ ] Test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [x] Major
   - [ ] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   Not yet tested, hoping CI/CD runs through some self-tests, then I'll try a test deployment.
   
   #### How did you try to break this feature and the system with this change?
   
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bradh352 (via GitHub)" <gi...@apache.org>.
bradh352 commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3462893615

   pretty sure the simulator failure is unrelated to my changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3471120993

   <b>[SF] Trillian test result (tid-14747)</b>
   Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 65004 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11932-t14747-kvm-ol8.zip
   Smoke tests completed. 148 look OK, 0 have errors, 1 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3643341091

   > > > side-effect: these will be set by default, hope no regressions.
   > > 
   > > 
   > > yes, but only if memballoon is enabled on the host, right?
   > 
   > correct, if memballoon is enabled for the KVM host, this is enabled automatically. There is no impact if memballoon is disabled.
   > 
   > As far as I can tell with memballoon, there was no actual KVM integration within cloudstack that would do anything useful. Adding these flags makes it actually do something useful.
   
   I remember some users get the real memory usage by enabling memory ballooning. maybe they can test 
   cc @JoaoJandre  @bernardodemarco 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2474276069


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,11 @@ public String getMemBalloonStatsPeriod() {
         @Override
         public String toString() {
             StringBuilder memBalloonBuilder = new StringBuilder();
-            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'>\n");
+            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'");
+            if (memBalloonModel != MemBalloonModel.NONE) {

Review Comment:
   ok, good enough.
   have you checked the qemu version ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3625717646

   @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3661190709

   @weizhouapache I tested in a lab and @bradh352 is using it in production. Do we need more testing? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3462654918

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bradh352 (via GitHub)" <gi...@apache.org>.
bradh352 commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2474336054


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,11 @@ public String getMemBalloonStatsPeriod() {
         @Override
         public String toString() {
             StringBuilder memBalloonBuilder = new StringBuilder();
-            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'>\n");
+            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'");
+            if (memBalloonModel != MemBalloonModel.NONE) {

Review Comment:
   This was added in qemu 5.1 and requires host kernel 5.7.
   
   ubuntu 22.04 is qemu 6.2: https://launchpad.net/ubuntu/jammy/+source/qemu
   rocky linux 9 is qemu 9.1: https://download.rockylinux.org/pub/rocky/9/AppStream/x86_64/os/Packages/q/qemu-kvm-9.1.0-15.el9_6.9.x86_64.rpm
   
   So no problems there either.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3661210699

   > @weizhouapache I tested in a lab and @bradh352 is using it in production. Do we need more testing?
   
   I have approved it.
   there is no objections in last 5 days, I think we can merge.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bhouse-nexthop (via GitHub)" <gi...@apache.org>.
bhouse-nexthop commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3602873890

   @bernardodemarco I did get .deb files generated using your method above like `./dist/debbuild/DEBS/cloudstack-agent_4.22.1.0-SNAPSHOT~focal_all.deb` But given that the image is ubuntu 20.04 is there any problem trying to actually install and this on ubuntu 24.04?  I didn't see a docker template for ubuntu 24.04 available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bradh352 (via GitHub)" <gi...@apache.org>.
bradh352 commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3607149640

   Well, honestly the first test was enough to convince me it is working well:
   
   
   Fresh VM (wihtin VM):
   ```
   root@test1:~# free
                  total        used        free      shared  buff/cache   available
   Mem:        16369284      617328    15567232       11004      474740    15751956
   Swap:              0           0           0
   ```
   
   In Hypervisor:
   ```
   root@node1:~# ps -o pid,rss,vsz,command -p 1417359
       PID   RSS    VSZ COMMAND
   1417359 1408680 19634724 /usr/bin/qemu-system-x86_64 -name guest=i-2-304-VM,...
   ```
   
   In VM, allocate a tmpfs mount and a large file:
   ```
   root@test1:~# mount -t tmpfs tmpfs /mnt
   root@test1:~# dd if=/dev/zero of=/mnt/bigfile bs=1M count=10000
   dd: error writing '/mnt/bigfile': No space left on device
   7993+0 records in
   7992+0 records out
   8381071360 bytes (8.4 GB, 7.8 GiB) copied, 3.95783 s, 2.1 GB/s
   root@test1:~# free
                  total        used        free      shared  buff/cache   available
   Mem:        16369284     8805920     7369168     8195644     8678156     7563364
   Swap:              0           0           0
   ```
   
   In Hypervisor:
   ```
   root@node1:~# ps -o pid,rss,vsz,command -p 1417359
       PID   RSS    VSZ COMMAND
   1417359 9782676 19615192 /usr/bin/qemu-system-x86_64 -name guest=i-2-304-VM,...
   ```
   
   Cleanup:
   ```
   root@test1:~# rm -f /mnt/bigfile && umount /mnt
   root@test1:~# free
                  total        used        free      shared  buff/cache   available
   Mem:        16369284      599236    15467600       11004      594464    15770048
   Swap:              0           0           0
   ```
   
   In Hypervisor:
   ```
   root@node1:~# ps -o pid,rss,vsz,command -p 1417359
       PID   RSS    VSZ COMMAND
   1417359 1523988 19610052 /usr/bin/qemu-system-x86_64 -name guest=i-2-304-VM,...
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bhouse-nexthop (via GitHub)" <gi...@apache.org>.
bhouse-nexthop commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3643143239

   > > side-effect: these will be set by default, hope no regressions.
   > 
   > yes, but only if memballoon is enabled on the host, right?
   
   correct, if memballoon is enabled for the KVM host, this is enabled automatically.  There is no impact if memballoon is disabled.
   
   As far as I can tell with memballoon, there was no actual KVM integration within cloudstack that would do anything useful.  Adding these flags makes it actually do something useful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2473674526


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,11 @@ public String getMemBalloonStatsPeriod() {
         @Override
         public String toString() {
             StringBuilder memBalloonBuilder = new StringBuilder();
-            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'>\n");
+            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'");
+            if (memBalloonModel != MemBalloonModel.NONE) {

Review Comment:
   add libvirt version check ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3610492888

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15913


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3462683734

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11932?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 3.58%. Comparing base ([`8089d32`](https://app.codecov.io/gh/apache/cloudstack/commit/8089d32740320171f63d3f66d0abd429f455caf5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d81c695`](https://app.codecov.io/gh/apache/cloudstack/commit/d81c695b3a38569a5c9e95f6bc366e34151fa612?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 160 commits behind head on main.
   > :exclamation:  There is a different number of reports uploaded between BASE (8089d32) and HEAD (d81c695). Click for more details.
   > 
   > <details><summary>HEAD has 1 upload less than BASE</summary>
   >
   >| Flag | BASE (8089d32) | HEAD (d81c695) |
   >|------|------|------|
   >|unittests|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##               main   #11932       +/-   ##
   =============================================
   - Coverage     17.36%    3.58%   -13.78%     
   =============================================
     Files          5888      445     -5443     
     Lines        525831    37532   -488299     
     Branches      64183     6901    -57282     
   =============================================
   - Hits          91298     1346    -89952     
   + Misses       424227    36022   -388205     
   + Partials      10306      164    -10142     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11932/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11932/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.58% <ø> (-0.05%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11932/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11932?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3473335588

   > I'd rather not figure out how to build .deb packages for it if I don't have to :)
   
   @bradh352, I personally use this DEB builder: https://github.com/scclouds/cloudstack-deb-builder. 
   
   By default, it does not populate the `cloudstack-management` DEB with the system VM template and, therefore, the resulting package is more lightweight. However, the ACS environment must have the correct system VM template configured before installing the PR's packages.
   
   To build the packages, go to the Apache CloudStack source code root directory and execute:
   
   ```
   docker run -v <code-path>:/mnt/build/cloudstack -v ~/.m2:/root/.m2 -e "USER_ID=$(id -u)" -e "USER_GID=$(id -g)" -e "ACS_BUILD_OPTS=-T <number-of-threads> -DskipTests" scclouds/cloudstack-deb-builder:ubuntu2004-jdk11-python3
   ```  
   
   Where:
   - `<code-path>` is the path of the Apache CloudStack source code directory; and,
   - `<number-of-threads>` is the number of threads that will be used to build the artifacts.
   
   For example:
   
   ```
   docker run -v ~/code/cloudstack:/mnt/build/cloudstack -v ~/.m2:/root/.m2 -e "USER_ID=$(id -u)" -e "USER_GID=$(id -g)" -e "ACS_BUILD_OPTS=-T 4 -DskipTests" scclouds/cloudstack-deb-builder:ubuntu2004-jdk11-python3
   ```
   
   It may take a little bit longer for the first build process to finish, due to the download process of some dependencies. After it is finished, the DEB packages will be located inside the Apache CloudStack source code directory, at the `/dist/debbuild/DEBS` path.
   
   Hope it helps!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bradh352 (via GitHub)" <gi...@apache.org>.
bradh352 commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2579095320


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,13 @@ public String getMemBalloonStatsPeriod() {
         @Override
         public String toString() {
             StringBuilder memBalloonBuilder = new StringBuilder();
-            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'>\n");
+            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'");
+            /* Version integer format: major * 1,000,000 + minor * 1,000 + release.
+             * Require: libvirt 6.9.0, qemu 5.1.0 */
+            if (memBalloonModel != MemBalloonModel.NONE && s_qemuVersion >= 5001000 && s_libvirtVersion >= 6009000) {

Review Comment:
   @bernardodemarco I'm unfortunately not familiar with the specifics of javadoc so its not clear to me how to apply this to something other than a method itself.  I can update it if you let me know how it needs to be formatted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3632412577

   tested in a lab env executing `echo {1..10000000}` in the vm and monitoring the host with `watch free`. I can see the host memory shoot up and when the shell is aborted due to stack overflow, the host memory gos to the original state again. I am not sure if my test is adequate enough though. cc @bradh352 @weizhouapache @rajujith @bernardodemarco .
   
   I lean towards merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "rajujith (via GitHub)" <gi...@apache.org>.
rajujith commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3610116913

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3466491713

   @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3466489480

   @blueorangutan test keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3472983772

   > @weizhouapache looks like the smoke test passed
   
   good @bradh352 
   now let's wait someone to test it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3629977253

   <b>[SF] Trillian test result (tid-14914)</b>
   Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
   Total time taken: 56092 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11932-t14914-kvm-ol8.zip
   Smoke tests completed. 145 look OK, 4 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_uservm_host_control_state | `Failure` | 16.96 | test_host_control_state.py
   ContextSuite context=TestHostControlState>:teardown | `Error` | 30.42 | test_host_control_state.py
   test_01_vpn_usage | `Error` | 1.09 | test_usage.py
   test_01_migrate_VM_and_root_volume | `Error` | 86.57 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 28.54 | test_vm_life_cycle.py
   test_01_secure_vm_migration | `Error` | 179.26 | test_vm_life_cycle.py
   test_01_secure_vm_migration | `Error` | 179.27 | test_vm_life_cycle.py
   test_hostha_enable_ha_when_host_disabled | `Error` | 1.66 | test_hostha_kvm.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.85 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3640648951

   > side-effect: these will be set by default, hope no regressions.
   
   yes, but only if memballoon is enabled on the host, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bhouse-nexthop (via GitHub)" <gi...@apache.org>.
bhouse-nexthop commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3633473887

   We are running this in production now on a heavily over-provisioned private cloud used for development VMs where a developer may allocate 64G or more RAM, but only use them in "bursts" while compiling code.
   
   We also set up an hourly cron job in our dev vm template that developers use which does
   ```
   echo 1 > /proc/sys/vm/drop_caches
   echo 1 > /proc/sys/vm/compact_memory
   ```
   (as otherwise the buffers/cache in the VM will hold a lot of memory that can't be released).
   
   And the results have been nothing short of amazing.  We went from being maxed out on memory usage on each host to only utilizing 25%.
   
   This is an unusual use case, but has been phenomenal for us.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3637732400

   @bernardodemarco , any issues that would stop us from merging?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bradh352 (via GitHub)" <gi...@apache.org>.
bradh352 commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3599458662

   > > I'd rather not figure out how to build .deb packages for it if I don't have to :)
   > 
   > @bradh352, I personally use this DEB builder: https://github.com/scclouds/cloudstack-deb-builder.
   > 
   > By default, it does not populate the `cloudstack-management` DEB with the system VM template and, therefore, the resulting package is more lightweight. However, the ACS environment must have the correct system VM template configured before installing the PR's packages.
   > 
   > To build the packages, go to the Apache CloudStack source code root directory and execute:
   > 
   > ```
   > docker run -v <code-path>:/mnt/build/cloudstack -v ~/.m2:/root/.m2 -e "USER_ID=$(id -u)" -e "USER_GID=$(id -g)" -e "ACS_BUILD_OPTS=-T <number-of-threads> -DskipTests" scclouds/cloudstack-deb-builder:ubuntu2004-jdk11-python3
   > ```
   > 
   > Where:
   > 
   > * `<code-path>` is the path of the Apache CloudStack source code directory; and,
   > * `<number-of-threads>` is the number of threads that will be used to build the artifacts.
   > 
   > For example:
   > 
   > ```
   > docker run -v ~/code/cloudstack:/mnt/build/cloudstack -v ~/.m2:/root/.m2 -e "USER_ID=$(id -u)" -e "USER_GID=$(id -g)" -e "ACS_BUILD_OPTS=-T 4 -DskipTests" scclouds/cloudstack-deb-builder:ubuntu2004-jdk11-python3
   > ```
   > 
   > It may take a little bit longer for the first build process to finish, due to the download process of some dependencies. After it is finished, the DEB packages will be located inside the Apache CloudStack source code directory, at the `/dist/debbuild/DEBS` path.
   > 
   > Hope it helps!
   
   Thanks, I'm going to test this out tomorrow!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3473017585

   > @weizhouapache is there a package artifact generated by this I can download and use to test? I'm still getting familiar with cloudstack, I'd rather not figure out how to build .deb packages for it if I don't have to :)
   
   we do not provide the packages publicly, as the cloudstack-management-xx.deb package is huge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bradh352 (via GitHub)" <gi...@apache.org>.
bradh352 commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3472999484

   @weizhouapache is there a package artifact generated by this I can download and use to test?  I'm still getting familiar with cloudstack, I'd rather not figure out how to build .deb packages for it if I don't have to :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2481556630


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,13 @@ public String getMemBalloonStatsPeriod() {
         @Override
         public String toString() {
             StringBuilder memBalloonBuilder = new StringBuilder();
-            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'>\n");
+            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'");
+            /* Version integer format: major * 1,000,000 + minor * 1,000 + release.
+             * Require: libvirt 6.9.0, qemu 5.1.0 */
+            if (memBalloonModel != MemBalloonModel.NONE && s_qemuVersion >= 5001000 && s_libvirtVersion >= 6009000) {

Review Comment:
   @bradh352, thanks for the PR, code looks good. Just one minor suggestion, could you extract this comment into a method's Javadoc string? For instance: 
   
   https://github.com/apache/cloudstack/blob/3d6cafe1936ed2403a1031cd5ad42dd205934412/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java#L2178-L2183 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3610121197

   @rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bradh352 (via GitHub)" <gi...@apache.org>.
bradh352 commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3606751562

   Ok, I have a custom built 4.22 with this PR installed in my test environment.
   
   virsh dumpxml of a running vm shows:
   ```
       <memballoon model='virtio' autodeflate='on' freePageReporting='on'>
         <stats period='10'/>
         <alias name='balloon0'/>
         <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
       </memballoon>
   ```
   
   And in turn the generated qemu command line has this:
   ```
   -device {"driver":"virtio-balloon-pci","id":"balloon0","deflate-on-oom":true,"free-page-reporting":true,"bus":"pci.0","addr":"0x6"}
   ```
   
   VMs start up just fine.  I'm going to now try to allocate a bunch of memory within a series of VMs and release it and inspect if the host is able to reclaim the memory.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bradh352 (via GitHub)" <gi...@apache.org>.
bradh352 commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2473904516


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,11 @@ public String getMemBalloonStatsPeriod() {
         @Override
         public String toString() {
             StringBuilder memBalloonBuilder = new StringBuilder();
-            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'>\n");
+            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'");
+            if (memBalloonModel != MemBalloonModel.NONE) {

Review Comment:
   I was thinking it doesn't look necessary.  This was introduced in v6.9.0.  I checked both the oldest non-EOL enterprise distros and they all have newer versions:
    * ubuntu 22.04 LTS: 8.0.0 https://launchpad.net/ubuntu/jammy/+source/libvirt
    * CentOS/AlmaLinux/RockyLinux 9: 10.10.0 https://download.rockylinux.org/pub/rocky/9/AppStream/x86_64/os/Packages/l/libvirt-10.10.0-7.7.el9_6.x86_64.rpm 
   
   even EOL versions like CentOS 8 had v 8.0.0...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3462662816

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3462664891

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3462926626

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15585


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2474793797


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,11 @@ public String getMemBalloonStatsPeriod() {
         @Override
         public String toString() {
             StringBuilder memBalloonBuilder = new StringBuilder();
-            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'>\n");
+            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'");
+            if (memBalloonModel != MemBalloonModel.NONE) {

Review Comment:
   looks ok.
   
   however, to be safer, I would still suggest you to add the libvirt and qemu check.
   you can reuse `s_qemuVersion` and `s_libvirtVersion` in the same class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bradh352 (via GitHub)" <gi...@apache.org>.
bradh352 commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2475679563


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,11 @@ public String getMemBalloonStatsPeriod() {
         @Override
         public String toString() {
             StringBuilder memBalloonBuilder = new StringBuilder();
-            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'>\n");
+            memBalloonBuilder.append("<memballoon model='" + memBalloonModel + "'");
+            if (memBalloonModel != MemBalloonModel.NONE) {

Review Comment:
   Ok, I added the version checks.  Btw, I see some version checks using the wrong format in the code during a grep:
   ```
   plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:1641:                        && s_qemuVersion >= 4200000 && s_libvirtVersion >= 6300000;
   ```
   Those would resolve to 4.200.0 and 6.300.0.  Should probably provide version helpers for checks to prevent errors like that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "bradh352 (via GitHub)" <gi...@apache.org>.
bradh352 commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3472887772

   @weizhouapache looks like the smoke test passed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3625714989

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3625858833

   <b>[SF] Trillian Build Failed (tid-14911)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KVM memballooning requires free page reporting and autodeflate [cloudstack]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#issuecomment-3661264295

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org