You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2014/12/08 23:48:19 UTC
Review Request 28827: PIG-4338: Fix test failures with JDK8
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28827/
-----------------------------------------------------------
Review request for pig.
Bugs: PIG-4338
https://issues.apache.org/jira/browse/PIG-4338
Repository: pig
Description
-------
Changes done:
- Fixed test failures caused by HashSet iteration order change in JDK 8.
- Changed javac version to 1.6 in build.xml. Should be changing it to 1.7 before we release pig 0.15. But for now at least made it 1.6
- Moved threadpool initialization to launchPig in TezLauncher. It was unnecessarily creating threadpool even for explain (TestTezCompiler).
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/build.xml 1643944
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhysicalPlan.java 1643944
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java 1643944
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezPrinter.java 1643944
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POShuffledValueInputTez.java 1643944
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POValueOutputTez.java 1643944
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/plan/DependencyOrderWalker.java 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/builtin/TestAvroStorage.java 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-2.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-3.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-1-OPTOFF.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2-OPTOFF.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-3.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-4-OPTOFF.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-5-OPTOFF.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Order-1.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-1.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-2.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-SkewJoin-1.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-1-OPTOFF.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-10-OPTOFF.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2-OPTOFF.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-4-OPTOFF.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6-OPTOFF.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7-OPTOFF.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8-OPTOFF.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9-OPTOFF.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9.gld 1643944
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/tez/TestTezJobControlCompiler.java 1643944
Diff: https://reviews.apache.org/r/28827/diff/
Testing
-------
Failing tests now pass against jdk7 and jdk8
Thanks,
Rohini Palaniswamy
Re: Review Request 28827: PIG-4338: Fix test failures with JDK8
Posted by Daniel Dai <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28827/#review64418
-----------------------------------------------------------
Ship it!
Thanks. Everything else looks good.
- Daniel Dai
On Dec. 8, 2014, 10:48 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28827/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 10:48 p.m.)
>
>
> Review request for pig.
>
>
> Bugs: PIG-4338
> https://issues.apache.org/jira/browse/PIG-4338
>
>
> Repository: pig
>
>
> Description
> -------
>
> Changes done:
> - Fixed test failures caused by HashSet iteration order change in JDK 8.
> - Changed javac version to 1.6 in build.xml. Should be changing it to 1.7 before we release pig 0.15. But for now at least made it 1.6
> - Moved threadpool initialization to launchPig in TezLauncher. It was unnecessarily creating threadpool even for explain (TestTezCompiler).
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/build.xml 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhysicalPlan.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezPrinter.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POShuffledValueInputTez.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POValueOutputTez.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/plan/DependencyOrderWalker.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/builtin/TestAvroStorage.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-3.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-1-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-3.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-4-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-5-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Order-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-SkewJoin-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-1-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-10-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-4-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/tez/TestTezJobControlCompiler.java 1643944
>
> Diff: https://reviews.apache.org/r/28827/diff/
>
>
> Testing
> -------
>
> Failing tests now pass against jdk7 and jdk8
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request 28827: PIG-4338: Fix test failures with JDK8
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On Dec. 8, 2014, 11:47 p.m., Daniel Dai wrote:
> > http://svn.apache.org/repos/asf/pig/trunk/build.xml, line 64
> > <https://reviews.apache.org/r/28827/diff/1/?file=785931#file785931line64>
> >
> > why 1.6?
>
> Daniel Dai wrote:
> Saw your comments in Jira. Does tests all pass in 1.6 now? Otherwise, I think we can go directly to 1.7.
>
> Rohini Palaniswamy wrote:
> I haven't run with 1.6 in a while. But kept it at 1.6 as 1.5 is deprecated and you wanted to keep support for 1.6 for sometime - https://issues.apache.org/jira/browse/PIG-4210?focusedCommentId=14171627&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14171627
>
> Daniel Dai wrote:
> 0.14.0 is being wrap off at that time, but for 0.15, it is still early and we can encourage some 1.7 only feature. How do you think?
Sure. If everything else is fine, I can change that to 1.7 before checkin.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28827/#review64304
-----------------------------------------------------------
On Dec. 8, 2014, 10:48 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28827/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 10:48 p.m.)
>
>
> Review request for pig.
>
>
> Bugs: PIG-4338
> https://issues.apache.org/jira/browse/PIG-4338
>
>
> Repository: pig
>
>
> Description
> -------
>
> Changes done:
> - Fixed test failures caused by HashSet iteration order change in JDK 8.
> - Changed javac version to 1.6 in build.xml. Should be changing it to 1.7 before we release pig 0.15. But for now at least made it 1.6
> - Moved threadpool initialization to launchPig in TezLauncher. It was unnecessarily creating threadpool even for explain (TestTezCompiler).
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/build.xml 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhysicalPlan.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezPrinter.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POShuffledValueInputTez.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POValueOutputTez.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/plan/DependencyOrderWalker.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/builtin/TestAvroStorage.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-3.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-1-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-3.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-4-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-5-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Order-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-SkewJoin-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-1-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-10-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-4-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/tez/TestTezJobControlCompiler.java 1643944
>
> Diff: https://reviews.apache.org/r/28827/diff/
>
>
> Testing
> -------
>
> Failing tests now pass against jdk7 and jdk8
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request 28827: PIG-4338: Fix test failures with JDK8
Posted by Daniel Dai <da...@gmail.com>.
> On Dec. 8, 2014, 11:47 p.m., Daniel Dai wrote:
> > http://svn.apache.org/repos/asf/pig/trunk/build.xml, line 64
> > <https://reviews.apache.org/r/28827/diff/1/?file=785931#file785931line64>
> >
> > why 1.6?
Saw your comments in Jira. Does tests all pass in 1.6 now? Otherwise, I think we can go directly to 1.7.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28827/#review64304
-----------------------------------------------------------
On Dec. 8, 2014, 10:48 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28827/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 10:48 p.m.)
>
>
> Review request for pig.
>
>
> Bugs: PIG-4338
> https://issues.apache.org/jira/browse/PIG-4338
>
>
> Repository: pig
>
>
> Description
> -------
>
> Changes done:
> - Fixed test failures caused by HashSet iteration order change in JDK 8.
> - Changed javac version to 1.6 in build.xml. Should be changing it to 1.7 before we release pig 0.15. But for now at least made it 1.6
> - Moved threadpool initialization to launchPig in TezLauncher. It was unnecessarily creating threadpool even for explain (TestTezCompiler).
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/build.xml 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhysicalPlan.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezPrinter.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POShuffledValueInputTez.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POValueOutputTez.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/plan/DependencyOrderWalker.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/builtin/TestAvroStorage.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-3.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-1-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-3.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-4-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-5-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Order-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-SkewJoin-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-1-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-10-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-4-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/tez/TestTezJobControlCompiler.java 1643944
>
> Diff: https://reviews.apache.org/r/28827/diff/
>
>
> Testing
> -------
>
> Failing tests now pass against jdk7 and jdk8
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request 28827: PIG-4338: Fix test failures with JDK8
Posted by Daniel Dai <da...@gmail.com>.
> On Dec. 8, 2014, 11:47 p.m., Daniel Dai wrote:
> > http://svn.apache.org/repos/asf/pig/trunk/build.xml, line 64
> > <https://reviews.apache.org/r/28827/diff/1/?file=785931#file785931line64>
> >
> > why 1.6?
>
> Daniel Dai wrote:
> Saw your comments in Jira. Does tests all pass in 1.6 now? Otherwise, I think we can go directly to 1.7.
>
> Rohini Palaniswamy wrote:
> I haven't run with 1.6 in a while. But kept it at 1.6 as 1.5 is deprecated and you wanted to keep support for 1.6 for sometime - https://issues.apache.org/jira/browse/PIG-4210?focusedCommentId=14171627&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14171627
0.14.0 is being wrap off at that time, but for 0.15, it is still early and we can encourage some 1.7 only feature. How do you think?
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28827/#review64304
-----------------------------------------------------------
On Dec. 8, 2014, 10:48 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28827/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 10:48 p.m.)
>
>
> Review request for pig.
>
>
> Bugs: PIG-4338
> https://issues.apache.org/jira/browse/PIG-4338
>
>
> Repository: pig
>
>
> Description
> -------
>
> Changes done:
> - Fixed test failures caused by HashSet iteration order change in JDK 8.
> - Changed javac version to 1.6 in build.xml. Should be changing it to 1.7 before we release pig 0.15. But for now at least made it 1.6
> - Moved threadpool initialization to launchPig in TezLauncher. It was unnecessarily creating threadpool even for explain (TestTezCompiler).
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/build.xml 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhysicalPlan.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezPrinter.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POShuffledValueInputTez.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POValueOutputTez.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/plan/DependencyOrderWalker.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/builtin/TestAvroStorage.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-3.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-1-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-3.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-4-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-5-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Order-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-SkewJoin-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-1-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-10-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-4-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/tez/TestTezJobControlCompiler.java 1643944
>
> Diff: https://reviews.apache.org/r/28827/diff/
>
>
> Testing
> -------
>
> Failing tests now pass against jdk7 and jdk8
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request 28827: PIG-4338: Fix test failures with JDK8
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On Dec. 8, 2014, 11:47 p.m., Daniel Dai wrote:
> > http://svn.apache.org/repos/asf/pig/trunk/build.xml, line 64
> > <https://reviews.apache.org/r/28827/diff/1/?file=785931#file785931line64>
> >
> > why 1.6?
>
> Daniel Dai wrote:
> Saw your comments in Jira. Does tests all pass in 1.6 now? Otherwise, I think we can go directly to 1.7.
I haven't run with 1.6 in a while. But kept it at 1.6 as 1.5 is deprecated and you wanted to keep support for 1.6 for sometime - https://issues.apache.org/jira/browse/PIG-4210?focusedCommentId=14171627&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14171627
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28827/#review64304
-----------------------------------------------------------
On Dec. 8, 2014, 10:48 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28827/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 10:48 p.m.)
>
>
> Review request for pig.
>
>
> Bugs: PIG-4338
> https://issues.apache.org/jira/browse/PIG-4338
>
>
> Repository: pig
>
>
> Description
> -------
>
> Changes done:
> - Fixed test failures caused by HashSet iteration order change in JDK 8.
> - Changed javac version to 1.6 in build.xml. Should be changing it to 1.7 before we release pig 0.15. But for now at least made it 1.6
> - Moved threadpool initialization to launchPig in TezLauncher. It was unnecessarily creating threadpool even for explain (TestTezCompiler).
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/build.xml 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhysicalPlan.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezPrinter.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POShuffledValueInputTez.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POValueOutputTez.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/plan/DependencyOrderWalker.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/builtin/TestAvroStorage.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-3.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-1-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-3.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-4-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-5-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Order-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-SkewJoin-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-1-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-10-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-4-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/tez/TestTezJobControlCompiler.java 1643944
>
> Diff: https://reviews.apache.org/r/28827/diff/
>
>
> Testing
> -------
>
> Failing tests now pass against jdk7 and jdk8
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request 28827: PIG-4338: Fix test failures with JDK8
Posted by Daniel Dai <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28827/#review64304
-----------------------------------------------------------
http://svn.apache.org/repos/asf/pig/trunk/build.xml
<https://reviews.apache.org/r/28827/#comment106938>
why 1.6?
- Daniel Dai
On Dec. 8, 2014, 10:48 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28827/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 10:48 p.m.)
>
>
> Review request for pig.
>
>
> Bugs: PIG-4338
> https://issues.apache.org/jira/browse/PIG-4338
>
>
> Repository: pig
>
>
> Description
> -------
>
> Changes done:
> - Fixed test failures caused by HashSet iteration order change in JDK 8.
> - Changed javac version to 1.6 in build.xml. Should be changing it to 1.7 before we release pig 0.15. But for now at least made it 1.6
> - Moved threadpool initialization to launchPig in TezLauncher. It was unnecessarily creating threadpool even for explain (TestTezCompiler).
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/pig/trunk/build.xml 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhysicalPlan.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezPrinter.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POShuffledValueInputTez.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POValueOutputTez.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/impl/plan/DependencyOrderWalker.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/builtin/TestAvroStorage.java 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Limit-3.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-1-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-3.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-4-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-MQ-5-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Order-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Rank-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-SkewJoin-1.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-1-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-10-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-2.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-4-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-6.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-7.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-8.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9-OPTOFF.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/data/GoldenFiles/tez/TEZC-Union-9.gld 1643944
> http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/tez/TestTezJobControlCompiler.java 1643944
>
> Diff: https://reviews.apache.org/r/28827/diff/
>
>
> Testing
> -------
>
> Failing tests now pass against jdk7 and jdk8
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>