You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/30 14:19:23 UTC
[GitHub] [apisix-dashboard] membphis opened a new issue #1165: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
membphis opened a new issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165
this is the recommended way.
If the user does not use it in this way, we can display a warning message on the dashboard.
It might be a good way to display it on the status page.
related issue: https://github.com/apache/apisix-dashboard/issues/1148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-772465995
`mismatch_nodes`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-764418795
**Backend**
- Provide the `version_check` API;
**Frontend**
- Call the above API when the page first shows, once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-772465263
> IMO, BE provide the API as follow. This API is used for checking the version of apisix and dashboard are matched.
>
> ```
> GET /apisix/admin/tool/version_match
> ```
>
> The response like this:
>
> ```
> {
> "code": "2000001 | 0",
> "message": "The version of apisix and dashboard are not matched.",
> "request_id": "",
> "data": {
> "matched": true | false,
> "dashboard_version": "2.3",
> "not_matched_nodes": [{
> "hostname": "apisix-deployment-5c845b74b-bsrjm",
> "version": "2.1"
> }]
> }
> }
> ```
maybe `mimatched_nodes` is better than `not_matched_nodes` .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-772448962
good to go
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-753740065
Agree with it.
Do this need to store the `version mapping` info in FE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-754348218
Now, the way to get apisix version is through `server_info`.And there is more than one apisix instance. So I think we can add an API like this `/version_check` to do the version check.
When FE called `/version_check`, the manger-api will traverse the apisix server info and give the response.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-772201649
IMO, BE provide the API as follow. This API is used for checking the version of apisix and dashboard are matched.
```
GET /apisix/admin/tool/version_match
```
The response like this:
```
{
"code": "2000001 | 0",
"message": "The version of apisix and dashboard are not matched.",
"request_id": "",
"data": {
"matched": true | false,
"dashboard_version": "2.3",
"not_matched_nodes": [{
"hostname": "apisix-deployment-5c845b74b-bsrjm",
"version": "2.1"
}]
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-753740814
The quick way to implement this is just adding some tips in README or some places;
I would prefer adding the `x-client-version: v2.3` header when sending a request, then the backend will check if it's compatible 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-770926932
When packaging, write a separate version file, which is a json string, is this ok?
We are only responsible for the packaged version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-772466683
> `mismatch_nodes`
Gotcha.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1165:
URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-764418795
**Backend**
- Provide the `version_check` API;
**Frontend**
- Call the above API when the page first shows, once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org