You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/02/14 23:22:01 UTC
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6005
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
IMPALA-3403: [DOCS] Pare back irrelevant installation info
Take out the path A / path B pages with CM and non-CM installation
techniques for packages and parcels.
Replace with steps for building from source, adapted from
http://impala.apache.org/downloads.html
Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
---
M docs/impala.ditamap
M docs/topics/impala_install.xml
2 files changed, 36 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/6005/1
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Changes build cleanly and topic looks good.
http://gerrit.cloudera.org:8080/#/c/6005/2/docs/topics/impala_install.xml
File docs/topics/impala_install.xml:
PS2, Line 43: Cloudera Enterprise Core
I assume that removal of this string is slated for a subsequent cleanup task?
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
Patch Set 3:
Jim, should I turn Laurel's +1 into my +2 or do you want to doublecheck the wording about the README pointer?
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Laurel Hale,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6005
to look at the new patch set (#3).
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
IMPALA-3403: [DOCS] Pare back irrelevant installation info
Take out the path A / path B pages with CM and non-CM installation
techniques for packages and parcels.
Replace with steps for building from source, adapted from
http://impala.apache.org/downloads.html
Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
---
M docs/impala.ditamap
M docs/topics/impala_install.xml
2 files changed, 37 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/6005/3
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
IMPALA-3403: [DOCS] Pare back irrelevant installation info
Take out the path A / path B pages with CM and non-CM installation
techniques for packages and parcels.
Replace with steps for building from source, adapted from
http://impala.apache.org/downloads.html
Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
---
M docs/impala.ditamap
M docs/topics/impala_install.xml
2 files changed, 40 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/6005/2
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
Patch Set 1:
(2 comments)
Thanks for doing this!
http://gerrit.cloudera.org:8080/#/c/6005/1/docs/topics/impala_install.xml
File docs/topics/impala_install.xml:
Line 48: When you work with or contribute to the Apache Impala project, you are typically in a developer
This is odd wording. I think it might be better to say that this guide has instructions for people who have built from source without presuming what people call their "role".
Line 66: for build instructions.
I think the README.md is the best place for build instructions, since that is tied with the tarball, while the wiki is whatever the latest thing is.
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
IMPALA-3403: [DOCS] Pare back irrelevant installation info
Take out the path A / path B pages with CM and non-CM installation
techniques for packages and parcels.
Replace with steps for building from source, adapted from
http://impala.apache.org/downloads.html
Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Reviewed-on: http://gerrit.cloudera.org:8080/6005
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins
---
M docs/impala.ditamap
M docs/topics/impala_install.xml
2 files changed, 37 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Jim Apple: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/68/
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6005/1/docs/topics/impala_install.xml
File docs/topics/impala_install.xml:
Line 66: <li>
> The README.md file:
Please make the README.md description note that this is where you can find a pointer to the build instructions, not just "special notices". I believe the wiki page is already bit-rotted. The IPMC also has asked for us to describe a pointer to the build instructions in the README.
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
Patch Set 3:
(2 comments)
Addressed comments. Fixed merge conflict because I had already updated the 'Cloudera' reference that Laurel pointed out.
http://gerrit.cloudera.org:8080/#/c/6005/1/docs/topics/impala_install.xml
File docs/topics/impala_install.xml:
Line 66: </li>
> Please make the README.md description note that this is where you can find
Done
http://gerrit.cloudera.org:8080/#/c/6005/2/docs/topics/impala_install.xml
File docs/topics/impala_install.xml:
PS2, Line 43: ase for Apache Hadoop
> I assume that removal of this string is slated for a subsequent cleanup tas
Done. Was intending to take care of stray 'Cloudera' references as a batch, but since I have this file open I'll do this one now.
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6005/1/docs/topics/impala_install.xml
File docs/topics/impala_install.xml:
Line 48: Follow these steps to set up Impala on a cluster by building from source:
> This is odd wording. I think it might be better to say that this guide has
Done
Line 66: <li>
> I think the README.md is the best place for build instructions, since that
The README.md file:
https://github.com/apache/incubator-impala/blob/master/README.md
currently is pretty slim pickings. It just says Impala requires Linux (no distro names or numbers) and for building, it sends the user elsewhere:
"See bin/bootstrap_build.sh."
Why don't I leave the link to the wiki for the time being, and add a reference to the README as well. We can reconsider taking out the wiki link if we later beef up the README file.
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3403: [DOCS] Pare back irrelevant installation info
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3403: [DOCS] Pare back irrelevant installation info
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81b1afbf04b93c322b9829d9e05e7af4243c37c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No