[GitHub] [cordova] purefan commented on issue #184: cordova create does not accept valid domain names containing dashes

[GitBox <gi...@apache.org>]

purefan commented on issue #184:
URL: https://github.com/apache/cordova/issues/184#issuecomment-647172246


   - If you say "reverse dns notation" then we expect it to accept hyphens
   - If you can't accept hyphens because of Android that's ok, but then we expect it to be documented (I could not find this behavior anywhere but maybe I missed it)
   
   For anyone else coming here through a web search:
   This repository pulls dependencies from other apache repositories, the validation for the id happens when this project calls [the cordova-cli routine for create](https://github.com/apache/cordova-cli/blob/838a05784a3bc040fbf1ec223fba976663954234/src/cli.js#L348) which in turn [runs the validation](https://github.com/apache/cordova-create/blob/5f24bdbceba46830a46dc940306688b2d71f447a/index.js#L68) from [valid-identifier](https://github.com/purplecabbage/valid-identifier)
   
   So one way to fix this _situation_ is to improve valid-identifier to throw an Error or implement some mechanism to bubble the offending part, seeing how valid-identifier has not been updated in a few years Id say chances of pull requests being accepted are slim
   
   In other words, maybe the best place for a bug report is the cordova-cli project, and not this one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org