You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/05/17 19:41:10 UTC

[GitHub] [celix] abroekhuis commented on pull request #234: Only disable optimizations for specific test, rather than entire celix

abroekhuis commented on pull request #234:
URL: https://github.com/apache/celix/pull/234#issuecomment-629849705


   While this does work, I don't feel really comfortable with it. Even though this test triggers the problem, the problem also seems to come from the ffi library.
   Are we certain it is due to the test? And if not, how certain are we that this will not happen in a released version?
   
   @pnoltes wdyt?
   
   Having said that, I'm fine with approving it, as long as we remember this is an issue, if it comes up again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org