[GitHub] [flink] xuzhiwen1255 opened a new pull request, #22223: [FLINK-31528] [table-planner] Move SqlCatalog* conversion logic to SqlNodeConverter

["xuzhiwen1255 (via GitHub)" <gi...@apache.org>]

xuzhiwen1255 opened a new pull request, #22223:
URL: https://github.com/apache/flink/pull/22223

   ## What is the purpose of the change
   Similar to [FLINK-31368](https://issues.apache.org/jira/browse/FLINK-31368), the SqlToOperationConverter is a bit bloated. 
   Introduce SqlNodeConverter for SqlCatalog*-related conversion logic
   
   ## Brief change log
   - Add SqlNodeConverter implementation of SqlUseCatalogConverter, SqlShowCatalogsConverter,SqlShowCatalogsConverter and SqlDropCatalogConverter
   
   ## Verifying this change
   This change is already covered by existing tests, such as (please describe tests).
   
   ## Does this pull request potentially affect one of the following parts:
   Dependencies (does it add or upgrade a dependency): no
   The public API, i.e., is any changed class annotated with @Public(Evolving):  no
   The serializers: no
   The runtime per-record code paths (performance sensitive):  no
   Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: 
    no
   The S3 file system connector:  no 
   
   ## Documentation
   Does this pull request introduce a new feature?  no
   If yes, how is the feature documented? not applicable 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22223: [FLINK-31528] [table-planner] Move SqlCatalog* conversion logic to SqlNodeConverter

["flinkbot (via GitHub)" <gi...@apache.org>]

flinkbot commented on PR #22223:
URL: https://github.com/apache/flink/pull/22223#issuecomment-1475791761

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8254c9dc1a8b22801e1497df45deb345aca8ddeb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8254c9dc1a8b22801e1497df45deb345aca8ddeb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8254c9dc1a8b22801e1497df45deb345aca8ddeb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org