You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2018/02/07 08:39:09 UTC
[GitHub] carbondata pull request #1941: [CARBONDATA1506] fix SDV error in PushUP_FILT...
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/1941
[CARBONDATA1506] fix SDV error in PushUP_FILTER_uniqdata_TC075
fix SDV error in PushUP_FILTER_uniqdata_TC075
2018.2.7:
http://144.76.159.231:8080/job/ApacheSDVTests/3387/testReport/junit/org.apache.carbondata.cluster.sdv.generated/QueriesBasicTestCase/PushUP_FILTER_uniqdata_TC075/
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata CARBONDATA1506_randomError
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1941.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1941
----
commit f01b1d9244a904c42665b1d347f2c1438f8c6044
Author: xubo245 <60...@...>
Date: 2018-02-07T08:34:53Z
[CARBONDATA1506] fix SDV error
integration/spark-common-test/src/test/resources/dd/
----
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1941
LGTM
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3404/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
@QiangCai @jackylk @sraghunandan @chenliang613 please review it
---
[GitHub] carbondata pull request #1941: [CARBONDATA1506] fix SDV error in PushUP_FILT...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1941#discussion_r171130148
--- Diff: integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/QueriesBasicTestCase.scala ---
@@ -4239,7 +4239,7 @@ class QueriesBasicTestCase extends QueryTest with BeforeAndAfterAll {
//PushUP_FILTER_uniqdata_TC075
test("PushUP_FILTER_uniqdata_TC075", Include) {
- checkAnswer(s"""select covar_samp(1,2) from uniqdata where CUST_ID IS NULL or DOB IS NOT NULL or BIGINT_COLUMN1 =1233720368578 or DECIMAL_COLUMN1 = 12345678901.1234000058 or Double_COLUMN1 = 1.12345674897976E10 or INTEGER_COLUMN1 IS NULL """,
+ checkAnswer(s"""select round(covar_samp(1,2), 4) from uniqdata where CUST_ID IS NULL or DOB IS NOT NULL or BIGINT_COLUMN1 =1233720368578 or DECIMAL_COLUMN1 = 12345678901.1234000058 or Double_COLUMN1 = 1.12345674897976E10 or INTEGER_COLUMN1 IS NULL """,
s"""select covar_samp(1,2) from uniqdata_hive where CUST_ID IS NULL or DOB IS NOT NULL or BIGINT_COLUMN1 =1233720368578 or DECIMAL_COLUMN1 = 12345678901.1234000058 or Double_COLUMN1 = 1.12345674897976E10 or INTEGER_COLUMN1 IS NULL """, "QueriesBasicTestCase_PushUP_FILTER_uniqdata_TC075")
--- End diff --
ok， done
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3418/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3720/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1941
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2719/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3420/
---
[GitHub] carbondata pull request #1941: [CARBONDATA1506] fix SDV error in PushUP_FILT...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1941#discussion_r170414673
--- Diff: integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/QueriesBasicTestCase.scala ---
@@ -4239,7 +4239,7 @@ class QueriesBasicTestCase extends QueryTest with BeforeAndAfterAll {
//PushUP_FILTER_uniqdata_TC075
test("PushUP_FILTER_uniqdata_TC075", Include) {
- checkAnswer(s"""select covar_samp(1,2) from uniqdata where CUST_ID IS NULL or DOB IS NOT NULL or BIGINT_COLUMN1 =1233720368578 or DECIMAL_COLUMN1 = 12345678901.1234000058 or Double_COLUMN1 = 1.12345674897976E10 or INTEGER_COLUMN1 IS NULL """,
+ checkAnswer(s"""select round(covar_samp(1,2), 4) from uniqdata where CUST_ID IS NULL or DOB IS NOT NULL or BIGINT_COLUMN1 =1233720368578 or DECIMAL_COLUMN1 = 12345678901.1234000058 or Double_COLUMN1 = 1.12345674897976E10 or INTEGER_COLUMN1 IS NULL """,
s"""select covar_samp(1,2) from uniqdata_hive where CUST_ID IS NULL or DOB IS NOT NULL or BIGINT_COLUMN1 =1233720368578 or DECIMAL_COLUMN1 = 12345678901.1234000058 or Double_COLUMN1 = 1.12345674897976E10 or INTEGER_COLUMN1 IS NULL """, "QueriesBasicTestCase_PushUP_FILTER_uniqdata_TC075")
--- End diff --
for "select covar_samp(1,2) from uniqdata_hive" also need to change
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1941
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3552/
---
[GitHub] carbondata pull request #1941: [CARBONDATA-1506] fix SDV error in PushUP_FIL...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1941
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3428/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3394/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3402/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
@chenliang613 CI pass
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3423/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1941
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3561/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/1941
LGTM
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3455/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3443/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
retest sdv please
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3416/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1941
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3964/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1941
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2315/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1941
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2324/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3417/
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1941
@QiangCai @chenliang613 @sraghunandan @jackylk Please review it
---
[GitHub] carbondata issue #1941: [CARBONDATA1506] fix SDV error in PushUP_FILTER_uniq...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1941
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3451/
---