[GitHub] [accumulo] ctubbsii commented on issue #2520: Exceptions and Errors ignored due to unchecked Futures

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #2520:
URL: https://github.com/apache/accumulo/issues/2520#issuecomment-1049463464


   We probably shouldn't be adding SuppressWarnings for errorprone-specific warnings. I've found it to be quite annoying in Eclipse (and perhaps in other IDEs) when warnings that it doesn't recognize are suppressed. In such cases, it actually generates new warnings. But, the only option to hide those warnings about "unnecessary suppressions" is to turn that off entirely... and then it doesn't catch legitimate typos for standard warnings suppressions. I hit this hard when I found that Eclipse doesn't recognize a standard warning "overloads": https://bugs.eclipse.org/bugs/show_bug.cgi?id=559000
   
   I would prefer ignoring warnings categorically that we don't care about in the POM, and have it just fail the build (when that profile is active) when it catches something we do care about. I would prefer to avoid suppressions.
   
   As for this bug with regard to Futures, does this only affect 2.1.0-SNAPSHOT? Or does it affect anything else?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org