You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "szehon-ho (via GitHub)" <gi...@apache.org> on 2026/06/11 00:43:28 UTC
[PR] [SPARK-57382][INFRA] Default merge script JIRA assignee prompt to reporter [spark]
szehon-ho opened a new pull request, #56443:
URL: https://github.com/apache/spark/pull/56443
### What changes were proposed in this pull request?
In `dev/merge_spark_pr.py`, the `choose_jira_assignee` prompt now defaults to the JIRA reporter when one exists. The reporter is placed at index `[0]` in the candidate list, and the prompt uses the standard `[default]` convention used by the other prompts in the script, e.g.:
```
Enter number of user, or userid, to assign to [Reporter Name]:
```
Pressing enter (blank) assigns the reporter. When there is no reporter, the prompt keeps the previous wording and a blank entry still leaves the issue unassigned:
```
Enter number of user, or userid, to assign to (blank to leave unassigned):
```
### Why are the changes needed?
Previously a blank entry left the issue unassigned, with no default offered. The reporter is by far the most common assignee, so defaulting to it on blank input saves a step and makes the prompt consistent with the other `[default]`-style prompts in the script (e.g. branch name and fix versions).
### Does this PR introduce _any_ user-facing change?
No. This only affects the committer-facing merge tooling (`dev/merge_spark_pr.py`).
### How was this patch tested?
Exercised `choose_jira_assignee` directly with a stubbed input function and a fake issue object (no real merge or JIRA connection), covering three cases:
- reporter present + blank input -> assigns the reporter (index `[0]`)
- reporter present + numeric pick -> assigns the selected commentator
- no reporter + blank input -> returns unassigned, no assign call
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Cursor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57382][INFRA] Default merge script JIRA assignee prompt to reporter [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho closed pull request #56443: [SPARK-57382][INFRA] Default merge script JIRA assignee prompt to reporter
URL: https://github.com/apache/spark/pull/56443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57382][INFRA] Default merge script JIRA assignee prompt to reporter [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #56443:
URL: https://github.com/apache/spark/pull/56443#issuecomment-4676120807
hi @gaogaotiantian @dongjoon-hyun does this make sense? realize running the merge script that i usually change the default in this part (as opposed to the others that are more smooth).
But please double check my assumption, that majority of time the Reporter is the one we should assign to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57382][INFRA] Default merge script JIRA assignee prompt to reporter [spark]
Posted by "gaogaotiantian (via GitHub)" <gi...@apache.org>.
gaogaotiantian commented on PR #56443:
URL: https://github.com/apache/spark/pull/56443#issuecomment-4676372725
I agree that traditionally the reporter is often not the same as the assignee. It's just most of the JIRA tickets are placeholders for the actual PRs now. Not sure if this is ideal. If we can somehow link the author of the PR to JIRA account, that's a pretty good assumption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57382][INFRA] Default merge script JIRA assignee prompt to reporter [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #56443:
URL: https://github.com/apache/spark/pull/56443#issuecomment-4714335563
Sounds good. Yea, I thought in Agentic era, most JIRA's are created as part of the create_jira script as part of the 'create pr' workflow, hence my initial thought.
I took a look, there's no good way to get a mapping between JIRA id and github id. (The result of the JIRA query fuzzes some fields). Looks like there's no way forward with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org