You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2017/12/21 19:56:33 UTC

svn commit: r1818974 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/LayerUtility.java

Author: tilman
Date: Thu Dec 21 19:56:33 2017
New Revision: 1818974

URL: http://svn.apache.org/viewvc?rev=1818974&view=rev
Log:
PDFBOX-4044: warn if negative cropbox origin

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/LayerUtility.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/LayerUtility.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/LayerUtility.java?rev=1818974&r1=1818973&r2=1818974&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/LayerUtility.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/multipdf/LayerUtility.java Thu Dec 21 19:56:33 2017
@@ -22,6 +22,8 @@ import java.io.OutputStream;
 import java.util.Arrays;
 import java.util.Map;
 import java.util.Set;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 import org.apache.fontbox.util.BoundingBox;
 import org.apache.pdfbox.cos.COSArray;
@@ -49,6 +51,8 @@ import org.apache.pdfbox.util.Matrix;
  */
 public class LayerUtility
 {
+    private static final Log LOG = LogFactory.getLog(LayerUtility.class);
+
     private static final boolean DEBUG = true;
 
     private final PDDocument targetDoc;
@@ -252,6 +256,14 @@ public class LayerUtility
             throw new IllegalArgumentException("Optional group (layer) already exists: " + layerName);
         }
 
+        PDRectangle cropBox = targetPage.getCropBox();
+        if ((cropBox.getLowerLeftX() < 0 || cropBox.getLowerLeftY() < 0) && transform.isIdentity())
+        {
+            // PDFBOX-4044 
+            LOG.warn("Negative cropBox " + cropBox + 
+                     " and identity transform may make your form invisible");
+        }
+
         PDOptionalContentGroup layer = new PDOptionalContentGroup(layerName);
         ocprops.addGroup(layer);