You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/12 18:16:37 UTC
[GitHub] [geode] gesterzhou commented on a change in pull request #6891: GEODE-9627: Add service provider interface to register DataSerializableFixedIDs
gesterzhou commented on a change in pull request #6891:
URL: https://github.com/apache/geode/pull/6891#discussion_r727383439
##########
File path: geode-wan/src/main/java/org/apache/geode/cache/wan/internal/client/locator/WANFactoryImpl.java
##########
@@ -27,37 +27,16 @@
import org.apache.geode.cache.wan.internal.GatewayReceiverFactoryImpl;
import org.apache.geode.cache.wan.internal.GatewaySenderFactoryImpl;
import org.apache.geode.distributed.internal.WanLocatorDiscoverer;
-import org.apache.geode.internal.InternalDataSerializer;
import org.apache.geode.internal.cache.InternalCache;
import org.apache.geode.internal.cache.wan.spi.WANFactory;
import org.apache.geode.internal.serialization.DataSerializableFixedID;
+import org.apache.geode.internal.serialization.DataSerializableFixedIdLoader;
+import org.apache.geode.internal.serialization.DataSerializableFixedIdRegistrar;
-public class WANFactoryImpl implements WANFactory {
+public class WANFactoryImpl implements WANFactory, DataSerializableFixedIdLoader {
@Override
- public void initialize() {
- InternalDataSerializer.getDSFIDSerializer().registerDSFID(
- DataSerializableFixedID.REMOTE_LOCATOR_JOIN_REQUEST,
- RemoteLocatorJoinRequest.class);
- InternalDataSerializer.getDSFIDSerializer().registerDSFID(
- DataSerializableFixedID.REMOTE_LOCATOR_JOIN_RESPONSE,
- RemoteLocatorJoinResponse.class);
- InternalDataSerializer.getDSFIDSerializer().registerDSFID(
- DataSerializableFixedID.REMOTE_LOCATOR_REQUEST,
- RemoteLocatorRequest.class);
- InternalDataSerializer.getDSFIDSerializer().registerDSFID(
- DataSerializableFixedID.LOCATOR_JOIN_MESSAGE,
- LocatorJoinMessage.class);
- InternalDataSerializer.getDSFIDSerializer().registerDSFID(
- DataSerializableFixedID.REMOTE_LOCATOR_PING_REQUEST,
- RemoteLocatorPingRequest.class);
- InternalDataSerializer.getDSFIDSerializer().registerDSFID(
- DataSerializableFixedID.REMOTE_LOCATOR_PING_RESPONSE,
- RemoteLocatorPingResponse.class);
- InternalDataSerializer.getDSFIDSerializer().registerDSFID(
- DataSerializableFixedID.REMOTE_LOCATOR_RESPONSE,
- RemoteLocatorResponse.class);
- }
+ public void initialize() {}
Review comment:
i like Kirk's idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org