You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "oneby-wang (via GitHub)" <gi...@apache.org> on 2026/01/20 05:59:49 UTC
[PR] [fix][broker] Fix ManagedCursorImpl.asyncDelete() method may lose previous async mark delete properties in race condition [pulsar]
oneby-wang opened a new pull request, #25165:
URL: https://github.com/apache/pulsar/pull/25165
### Motivation
`ManagedCursorImpl.asyncDelete()` method may lose previous async mark delete properties in race condition.
### Modifications
1. Add `testAsyncDeleteNeverLoseMarkDeleteProperties()` test to reproduce the issue.
2. Pass `null` to `internalAsyncMarkDelete()` method's properties param in `asyncDelete()` method.
3. Run test to verify the code change.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/oneby-wang/pulsar/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix ManagedCursorImpl.asyncDelete() method may lose previous async mark delete properties in race condition [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #25165:
URL: https://github.com/apache/pulsar/pull/25165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix ManagedCursorImpl.asyncDelete() method may lose previous async mark delete properties in race condition [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #25165:
URL: https://github.com/apache/pulsar/pull/25165#issuecomment-3772204070
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix ManagedCursorImpl.asyncDelete() method may lose previous async mark delete properties in race condition [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #25165:
URL: https://github.com/apache/pulsar/pull/25165#issuecomment-3771670131
Depends on #25110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix ManagedCursorImpl.asyncDelete() method may lose previous async mark delete properties in race condition [pulsar]
Posted by "oneby-wang (via GitHub)" <gi...@apache.org>.
oneby-wang commented on PR #25165:
URL: https://github.com/apache/pulsar/pull/25165#issuecomment-3775590789
`ExtensibleLoadManagerImplTest` in the flaky test suite always fails no matter how many times I rerun it in my personal CI(with or without this PR).
https://github.com/oneby-wang/pulsar/actions/runs/21156674861/job/60853773530?pr=25
https://github.com/oneby-wang/pulsar/actions/runs/21158046247/job/60853358807?pr=11
Seems some code changes break this flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] Fix ManagedCursorImpl.asyncDelete() method may lose previous async mark delete properties in race condition [pulsar]
Posted by "oneby-wang (via GitHub)" <gi...@apache.org>.
oneby-wang commented on PR #25165:
URL: https://github.com/apache/pulsar/pull/25165#issuecomment-3771750412
@lhotari PR description updated.
Some more places need further working:
1. `ManagedLedgerImpl.advanceCursorsIfNecessary()`
2. `PersistentMessageExpiryMonitor.findEntryComplete()`
3. `ManagedCursorImpl.internalResetCursor()`
I will address the three above references in separate PRs. First, I will write test cases to reproduce the issue, then fix it using the approach referenced in this PR.
Please kick me if I miss something.
<img width="1221" height="656" alt="image" src="https://github.com/user-attachments/assets/53610289-f06a-4b1a-9f09-64b969644783" />
<img width="1361" height="236" alt="image" src="https://github.com/user-attachments/assets/2931c0d6-6856-4deb-97df-620bab705c19" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org