[GitHub] [echarts] susiwen8 commented on a change in pull request #15314: Fix(polar): polar would throw error if no label

[GitBox <gi...@apache.org>]

susiwen8 commented on a change in pull request #15314:
URL: https://github.com/apache/echarts/pull/15314#discussion_r666592906



##########
File path: src/chart/bar/BarView.ts
##########
@@ -980,6 +980,11 @@ function updateStyle(
         }
     );
 
+    const label = el.getTextContent();
+    if (!label) {
+        return;
+    }
+
     if (isPolar) {
         const position = itemModel.get(['label', 'position']);
         el.textConfig.inside = position === 'middle' ? true : null;

Review comment:
       Thanks, maybe we should put  before https://github.com/apache/echarts/blob/6bd27bf3a0454abd68098ece9966ef2943543f19/src/chart/bar/BarView.ts#L989-L996 for which set label rotation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org