You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/02/14 05:56:26 UTC
Review Request 56643: Hive View 2.0 upload table issues : char
support, endline support and temp file deletion
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56643/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-19999
https://issues.apache.org/jira/browse/AMBARI-19999
Repository: ambari
Description
-------
following bugs in upload table feature have been resolved in this patch:
1. does not support to specify endlines in input file's fields
2. if column datatype is char or varchar it gives error.
3. temporary table does not get deleted if error occurs in table upload.
Options
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js 066168c
contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 29e9891
contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js b550dbe
contrib/views/hive20/src/main/resources/ui/app/models/column.js 73a9824
contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js 0e61905
contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs c63f502
contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs 4f3b98a
Diff: https://reviews.apache.org/r/56643/diff/
Testing
-------
manual testing done.
Thanks,
Nitiraj Rathore
Re: Review Request 56643: Hive View 2.0 upload table issues : char
support, endline support and temp file deletion
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56643/#review165518
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Feb. 14, 2017, 5:56 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56643/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 5:56 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19999
> https://issues.apache.org/jira/browse/AMBARI-19999
>
>
> Repository: ambari
>
>
> Description
> -------
>
> following bugs in upload table feature have been resolved in this patch:
> 1. does not support to specify endlines in input file's fields
> 2. if column datatype is char or varchar it gives error.
> 3. temporary table does not get deleted if error occurs in table upload.
> Options
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js 066168c
> contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 29e9891
> contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js b550dbe
> contrib/views/hive20/src/main/resources/ui/app/models/column.js 73a9824
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js 0e61905
> contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs c63f502
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs 4f3b98a
>
> Diff: https://reviews.apache.org/r/56643/diff/
>
>
> Testing
> -------
>
> manual testing done.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 56643: Hive View 2.0 upload table issues : char
support, endline support and temp file deletion
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56643/#review165475
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On Feb. 14, 2017, 5:56 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56643/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 5:56 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19999
> https://issues.apache.org/jira/browse/AMBARI-19999
>
>
> Repository: ambari
>
>
> Description
> -------
>
> following bugs in upload table feature have been resolved in this patch:
> 1. does not support to specify endlines in input file's fields
> 2. if column datatype is char or varchar it gives error.
> 3. temporary table does not get deleted if error occurs in table upload.
> Options
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js 066168c
> contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 29e9891
> contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js b550dbe
> contrib/views/hive20/src/main/resources/ui/app/models/column.js 73a9824
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js 0e61905
> contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs c63f502
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs 4f3b98a
>
> Diff: https://reviews.apache.org/r/56643/diff/
>
>
> Testing
> -------
>
> manual testing done.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 56643: Hive View 2.0 upload table issues : char
support, endline support and temp file deletion
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56643/#review165473
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 14, 2017, 5:56 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56643/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 5:56 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19999
> https://issues.apache.org/jira/browse/AMBARI-19999
>
>
> Repository: ambari
>
>
> Description
> -------
>
> following bugs in upload table feature have been resolved in this patch:
> 1. does not support to specify endlines in input file's fields
> 2. if column datatype is char or varchar it gives error.
> 3. temporary table does not get deleted if error occurs in table upload.
> Options
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js 066168c
> contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 29e9891
> contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js b550dbe
> contrib/views/hive20/src/main/resources/ui/app/models/column.js 73a9824
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js 0e61905
> contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs c63f502
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs 4f3b98a
>
> Diff: https://reviews.apache.org/r/56643/diff/
>
>
> Testing
> -------
>
> manual testing done.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>