You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Kostas Kloudas (JIRA)" <ji...@apache.org> on 2016/08/19 17:30:20 UTC

[jira] [Updated] (FLINK-4433) Refactor the StreamSource.

     [ https://issues.apache.org/jira/browse/FLINK-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kostas Kloudas updated FLINK-4433:
----------------------------------
    Description: 
With the addition of continuous file monitoring, apart from the {{StreamSource}} also the {{ContinuousFileReaderOperator}} uses a {{SourceContext}}. Given this, all the implementations of the {{SourceContext}} should be removed from the {{StreamSource}} and become independent classes.

In addition, the {{AsyncExceptionChecker}} interface should be removed as its functionality can be replaced by the {{task.failExternally()}} method. This also implies slight changes in the source context implementations. 

Also in the {{trigger()}} method of the {{WatermarkEmittingTask}}, all the {{owner.getCurrentProcessingTime()}} could be replaced by the {{timestamp}} argument of that method.

  was:
With the addition of continuous file monitoring, apart from the {{StreamSource}} also the {{ContinuousFileReaderOperator}} uses a {{SourceContext}}. Given this, all the implementations of the {{SourceContext}} should be removed from the {{StreamSource}} and become independent classes.

In addition, the {{AsyncExceptionChecker}} interface should be removed as its functionality can be replaced by the {{task.failExternally()}} method. This also implies slight changes in the source context implementations. 



> Refactor the StreamSource.
> --------------------------
>
>                 Key: FLINK-4433
>                 URL: https://issues.apache.org/jira/browse/FLINK-4433
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Kostas Kloudas
>
> With the addition of continuous file monitoring, apart from the {{StreamSource}} also the {{ContinuousFileReaderOperator}} uses a {{SourceContext}}. Given this, all the implementations of the {{SourceContext}} should be removed from the {{StreamSource}} and become independent classes.
> In addition, the {{AsyncExceptionChecker}} interface should be removed as its functionality can be replaced by the {{task.failExternally()}} method. This also implies slight changes in the source context implementations. 
> Also in the {{trigger()}} method of the {{WatermarkEmittingTask}}, all the {{owner.getCurrentProcessingTime()}} could be replaced by the {{timestamp}} argument of that method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)