You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2015/01/13 22:51:45 UTC

Review Request 29866: Upgrade pants to 0.0.27

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/
-----------------------------------------------------------

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Repository: aurora


Description
-------

Ports aurora repo to use pants 0.0.27 using the new pants new command processor.


Diffs
-----

  build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
  build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
  build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
  build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
  build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
  examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
  pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 

Diff: https://reviews.apache.org/r/29866/diff/


Testing
-------

bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Brian Wickman


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67987
-----------------------------------------------------------

Ship it!


Rad


pants
<https://reviews.apache.org/r/29866/#comment112102>

    good idea


- Joe Smith


On Jan. 13, 2015, 4:15 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 4:15 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Joshua Cohen <jc...@twopensource.com>.

> On Jan. 14, 2015, 12:49 a.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, line 21
> > <https://reviews.apache.org/r/29866/diff/3/?file=820203#file820203line21>
> >
> >     same, this doesn't appear to be related to a pants upgrade
> 
> Brian Wickman wrote:
>     this is to fix the test failure brought up by reviewbot.  unclear if it's related to the pants upgrade, but it should be fixed regardless.
> 
> Brian Wickman wrote:
>     would you prefer that this go into a separate review?
> 
> Kevin Sweeney wrote:
>     Yes, I prefer to keep commits small and focused (if I revert a commit titled "upgrade pants" I don't expect it to also break an unrelated test). Sorry if my comment made that unclear.

If the failure is caused by the pants upgrade, then it should ship w/ this review. If it's just an oversight from the initial commit of the resource manager, then split it out?


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67988
-----------------------------------------------------------


On Jan. 14, 2015, 12:15 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 12:15 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Brian Wickman <wi...@apache.org>.

> On Jan. 14, 2015, 12:49 a.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, line 21
> > <https://reviews.apache.org/r/29866/diff/3/?file=820203#file820203line21>
> >
> >     same, this doesn't appear to be related to a pants upgrade
> 
> Brian Wickman wrote:
>     this is to fix the test failure brought up by reviewbot.  unclear if it's related to the pants upgrade, but it should be fixed regardless.

would you prefer that this go into a separate review?


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67988
-----------------------------------------------------------


On Jan. 14, 2015, 12:15 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 12:15 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Bill Farner <wf...@apache.org>.

> On Jan. 14, 2015, 12:49 a.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, line 21
> > <https://reviews.apache.org/r/29866/diff/3/?file=820203#file820203line21>
> >
> >     same, this doesn't appear to be related to a pants upgrade
> 
> Brian Wickman wrote:
>     this is to fix the test failure brought up by reviewbot.  unclear if it's related to the pants upgrade, but it should be fixed regardless.
> 
> Brian Wickman wrote:
>     would you prefer that this go into a separate review?
> 
> Kevin Sweeney wrote:
>     Yes, I prefer to keep commits small and focused (if I revert a commit titled "upgrade pants" I don't expect it to also break an unrelated test). Sorry if my comment made that unclear.
> 
> Joshua Cohen wrote:
>     If the failure is caused by the pants upgrade, then it should ship w/ this review. If it's just an oversight from the initial commit of the resource manager, then split it out?
> 
> Brian Wickman wrote:
>     Well, reverting this change won't break that test -- the test passes on master and breaks with the pants upgrade.

I'm +1 to splitting it out, unless the test repeatably fails only with the new version of pants.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67988
-----------------------------------------------------------


On Jan. 14, 2015, 12:15 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 12:15 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Brian Wickman <wi...@apache.org>.

> On Jan. 14, 2015, 12:49 a.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, line 21
> > <https://reviews.apache.org/r/29866/diff/3/?file=820203#file820203line21>
> >
> >     same, this doesn't appear to be related to a pants upgrade
> 
> Brian Wickman wrote:
>     this is to fix the test failure brought up by reviewbot.  unclear if it's related to the pants upgrade, but it should be fixed regardless.
> 
> Brian Wickman wrote:
>     would you prefer that this go into a separate review?
> 
> Kevin Sweeney wrote:
>     Yes, I prefer to keep commits small and focused (if I revert a commit titled "upgrade pants" I don't expect it to also break an unrelated test). Sorry if my comment made that unclear.
> 
> Joshua Cohen wrote:
>     If the failure is caused by the pants upgrade, then it should ship w/ this review. If it's just an oversight from the initial commit of the resource manager, then split it out?

Well, reverting this change won't break that test -- the test passes on master and breaks with the pants upgrade.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67988
-----------------------------------------------------------


On Jan. 14, 2015, 12:15 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 12:15 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Kevin Sweeney <ke...@apache.org>.

> On Jan. 13, 2015, 4:49 p.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, line 21
> > <https://reviews.apache.org/r/29866/diff/3/?file=820203#file820203line21>
> >
> >     same, this doesn't appear to be related to a pants upgrade
> 
> Brian Wickman wrote:
>     this is to fix the test failure brought up by reviewbot.  unclear if it's related to the pants upgrade, but it should be fixed regardless.
> 
> Brian Wickman wrote:
>     would you prefer that this go into a separate review?

Yes, I prefer to keep commits small and focused (if I revert a commit titled "upgrade pants" I don't expect it to also break an unrelated test). Sorry if my comment made that unclear.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67988
-----------------------------------------------------------


On Jan. 13, 2015, 4:15 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 4:15 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Brian Wickman <wi...@apache.org>.

> On Jan. 14, 2015, 12:49 a.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, line 21
> > <https://reviews.apache.org/r/29866/diff/3/?file=820203#file820203line21>
> >
> >     same, this doesn't appear to be related to a pants upgrade

this is to fix the test failure brought up by reviewbot.  unclear if it's related to the pants upgrade, but it should be fixed regardless.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67988
-----------------------------------------------------------


On Jan. 14, 2015, 12:15 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 12:15 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67988
-----------------------------------------------------------



src/main/python/apache/aurora/executor/common/resource_manager.py
<https://reviews.apache.org/r/29866/#comment112103>

    Is this an unrelated change that snuck in?



src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
<https://reviews.apache.org/r/29866/#comment112104>

    same, this doesn't appear to be related to a pants upgrade


- Kevin Sweeney


On Jan. 13, 2015, 4:15 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 4:15 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review68469
-----------------------------------------------------------

Ship it!


Master (1346c4f) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 16, 2015, 7:16 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 7:16 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review68494
-----------------------------------------------------------

Ship it!


Thanks for doing this! Make sure you send a note to dev@ about the change

- Kevin Sweeney


On Jan. 16, 2015, 11:16 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 11:16 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/
-----------------------------------------------------------

(Updated Jan. 16, 2015, 7:16 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
-------

Remove changes to ResourceManager test.


Repository: aurora


Description
-------

Ports aurora repo to use pants 0.0.27 using the new pants new command processor.


Diffs (updated)
-----

  .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
  build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
  build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
  build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
  build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
  build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
  docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
  examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
  pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 

Diff: https://reviews.apache.org/r/29866/diff/


Testing
-------

bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Brian Wickman


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67996
-----------------------------------------------------------

Ship it!


Master (a350982) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 14, 2015, 12:15 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 12:15 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/
-----------------------------------------------------------

(Updated Jan. 14, 2015, 12:15 a.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
-------

Update developing-aurora-client.md


Repository: aurora


Description
-------

Ports aurora repo to use pants 0.0.27 using the new pants new command processor.


Diffs (updated)
-----

  .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
  build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
  build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
  build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
  build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
  build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
  docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
  examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
  pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
  src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
  src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 

Diff: https://reviews.apache.org/r/29866/diff/


Testing
-------

bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Brian Wickman


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Brian Wickman <wi...@apache.org>.

> On Jan. 14, 2015, 12:07 a.m., Maxim Khutornenko wrote:
> > Please, update docs/developing-aurora-client.md as well.

derp not sure how i missed that.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67979
-----------------------------------------------------------


On Jan. 14, 2015, 12:15 a.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2015, 12:15 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67979
-----------------------------------------------------------

Ship it!


Please, update docs/developing-aurora-client.md as well.

- Maxim Khutornenko


On Jan. 13, 2015, 11:20 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 11:20 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67982
-----------------------------------------------------------

Ship it!


Master (a350982) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 13, 2015, 11:20 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 11:20 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67977
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Cohen


On Jan. 13, 2015, 11:20 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 11:20 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 11:20 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
-------

Fix ResourceManager integration test.  Start using .pantsversion again.


Repository: aurora


Description
-------

Ports aurora repo to use pants 0.0.27 using the new pants new command processor.


Diffs (updated)
-----

  .pantsversion 43b29618309bc6aa441848513d5dd3554a32c7c1 
  build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
  build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
  build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
  build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
  build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
  examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
  pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
  src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 
  src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 

Diff: https://reviews.apache.org/r/29866/diff/


Testing
-------

bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Brian Wickman


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67957
-----------------------------------------------------------


Master (a350982) is red with this patch.
  ./build-support/jenkins/build.sh

                     src.test.python.apache.aurora.common.test_transport                             .....   SUCCESS
                     src.test.python.apache.aurora.config.test_base                                  .....   SUCCESS
                     src.test.python.apache.aurora.config.test_constraint_parsing                    .....   SUCCESS
                     src.test.python.apache.aurora.config.test_loader                                .....   SUCCESS
                     src.test.python.apache.aurora.config.test_thrift                                .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.announcer                         .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.directory_sandbox                 .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.executor_timeout                  .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.health_checker                    .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.kill_manager                      .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.resource_manager_integration      .....   FAILURE
                     src.test.python.apache.aurora.executor.common.status_checker                    .....   SUCCESS
                     src.test.python.apache.aurora.executor.common.task_info                         .....   SUCCESS
                     src.test.python.apache.aurora.executor.executor_base                            .....   SUCCESS
                     src.test.python.apache.aurora.executor.executor_detector                        .....   SUCCESS
                     src.test.python.apache.aurora.executor.executor_vars                            .....   SUCCESS
                     src.test.python.apache.aurora.executor.gc_executor                              .....   SUCCESS
                     src.test.python.apache.aurora.executor.status_manager                           .....   SUCCESS
                     src.test.python.apache.aurora.executor.thermos_executor                         .....   SUCCESS
                     src.test.python.apache.aurora.executor.thermos_task_runner                      .....   SUCCESS
                     src.test.python.apache.thermos.bin.test_thermos                                 .....   SUCCESS
                     src.test.python.apache.thermos.common.test_pathspec                             .....   SUCCESS
                     src.test.python.apache.thermos.common.test_planner                              .....   SUCCESS
                     src.test.python.apache.thermos.common.test_task_planner                         .....   SUCCESS
                     src.test.python.apache.thermos.config.test_schema                               .....   SUCCESS
                     src.test.python.apache.thermos.core.test_angry                                  .....   SUCCESS
                     src.test.python.apache.thermos.core.test_ephemerals                             .....   SUCCESS
                     src.test.python.apache.thermos.core.test_failing_runner                         .....   SUCCESS
                     src.test.python.apache.thermos.core.test_failure_limit                          .....   SUCCESS
                     src.test.python.apache.thermos.core.test_finalization                           .....   SUCCESS
                     src.test.python.apache.thermos.core.test_helper                                 .....   SUCCESS
                     src.test.python.apache.thermos.core.test_process                                .....   SUCCESS
                     src.test.python.apache.thermos.core.test_runner_integration                     .....   SUCCESS
                     src.test.python.apache.thermos.core.test_staged_kill                            .....   SUCCESS
                     src.test.python.apache.thermos.monitoring.test_disk                             .....   SUCCESS
                     
FAILURE


               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 13, 2015, 9:51 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 9:51 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Brian Wickman <wi...@apache.org>.

> On Jan. 13, 2015, 11:01 p.m., Brian Wickman wrote:
> > @ReviewBot retry

n/m this is reproducible.  just not caught by end to end test.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67965
-----------------------------------------------------------


On Jan. 13, 2015, 9:51 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 9:51 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67965
-----------------------------------------------------------


@ReviewBot retry

- Brian Wickman


On Jan. 13, 2015, 9:51 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 9:51 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 29866: Upgrade pants to 0.0.27

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67967
-----------------------------------------------------------



build-support/python/make-pycharm-virtualenv
<https://reviews.apache.org/r/29866/#comment112054>

    We changed to src/test/python:: in the build script, but we're still using src/test/python:all here. Should they be the same?



pants
<https://reviews.apache.org/r/29866/#comment112055>

    What if we have a file in the root like pants.version that's sourced by this and by update-pants-requirements rather than having to keep the version in sync between the two?


- Joshua Cohen


On Jan. 13, 2015, 9:51 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29866/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 9:51 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ports aurora repo to use pants 0.0.27 using the new pants new command processor.
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh 8de19cd865f3ae36c7ddc1aa0a8b453f95541b50 
>   build-support/pants_requirements.txt 9a790f973cc7560980d43d5a1097338ff88a0397 
>   build-support/python/make-pycharm-virtualenv 85e8137e8cab9765bd78ada6dedc9c60cc88e8a0 
>   build-support/python/update-pants-requirements 523a3cb7e87146dc393d9ab09b23f2e3fb683b27 
>   build-support/release/make-python-sdists 2f437d33928cc429a79aedb00247d472953fbb95 
>   examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd 
>   pants 40ddcf3a2c7359686ad326dd3d8ee37df55790e6 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py f8cf9fc7f0ed58be2bd2af5124e1a5df0dd2f00c 
> 
> Diff: https://reviews.apache.org/r/29866/diff/
> 
> 
> Testing
> -------
> 
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>