You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2021/05/23 02:15:00 UTC

[spark] branch branch-3.0 updated: [SPARK-35463][BUILD][FOLLOWUP] Redirect output for skipping checksum check

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.0 by this push:
     new 4994c7b  [SPARK-35463][BUILD][FOLLOWUP] Redirect output for skipping checksum check
4994c7b is described below

commit 4994c7b65b69ad8332b00872cbc975fc1c83c76a
Author: Liang-Chi Hsieh <vi...@gmail.com>
AuthorDate: Sat May 22 19:13:33 2021 -0700

    [SPARK-35463][BUILD][FOLLOWUP] Redirect output for skipping checksum check
    
    ### What changes were proposed in this pull request?
    
    This patch is a followup of SPARK-35463. In SPARK-35463, we output a message to stdout and now we redirect it to stderr.
    
    ### Why are the changes needed?
    
    All `echo` statements in `build/mvn` should redirect to stderr if it is not followed by `exit`. It is because we use `build/mvn` to get stdout output by other scripts. If we don't redirect it, we can get invalid output, e.g. got "Skipping checksum because shasum is not installed." as `commons-cli` version.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No. Dev only.
    
    ### How was this patch tested?
    
    Manually test on internal system.
    
    Closes #32637 from viirya/fix-build.
    
    Authored-by: Liang-Chi Hsieh <vi...@gmail.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
    (cherry picked from commit 594ffd2db224c89f5375645a7a249d4befca6163)
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 build/mvn | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build/mvn b/build/mvn
index 39b9a48..0d2da62 100755
--- a/build/mvn
+++ b/build/mvn
@@ -93,7 +93,7 @@ install_app() {
         fi
       fi
     else
-      echo "Skipping checksum because shasum is not installed."
+      echo "Skipping checksum because shasum is not installed." 1>&2
     fi
 
     cd "${_DIR}" && tar -xzf "${local_tarball}"

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org