You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/05/24 03:13:17 UTC
[GitHub] [incubator-dolphinscheduler] codecov-commenter commented on pull request #2730: simply logic inside MasterBaseTaskExecThread.submit method
codecov-commenter commented on pull request #2730:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2730#issuecomment-633172354
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730?src=pr&el=h1) Report
> Merging [#2730](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1771aa50d5f00e30fd0ac1e166206c9e2b8e2001&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `26.47%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2730 +/- ##
============================================
- Coverage 37.19% 37.16% -0.03%
- Complexity 2554 2555 +1
============================================
Files 434 434
Lines 19977 19983 +6
Branches 2423 2422 -1
============================================
- Hits 7430 7427 -3
- Misses 11880 11889 +9
Partials 667 667
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...server/master/runner/MasterBaseTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyQmFzZVRhc2tFeGVjVGhyZWFkLmphdmE=) | `39.50% <26.47%> (+1.23%)` | `9.00 <5.00> (+2.00)` | |
| [...duler/server/entity/DataxTaskExecutionContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2VudGl0eS9EYXRheFRhc2tFeGVjdXRpb25Db250ZXh0LmphdmE=) | `35.00% <0.00%> (-60.00%)` | `7.00% <0.00%> (-6.00%)` | |
| [...ver/master/consumer/TaskPriorityQueueConsumer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9jb25zdW1lci9UYXNrUHJpb3JpdHlRdWV1ZUNvbnN1bWVyLmphdmE=) | `54.41% <0.00%> (-4.42%)` | `16.00% <0.00%> (ø%)` | |
| [...he/dolphinscheduler/common/utils/RetryerUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1JldHJ5ZXJVdGlscy5qYXZh) | `100.00% <0.00%> (ø)` | `11.00% <0.00%> (+3.00%)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `53.95% <0.00%> (+0.71%)` | `11.00% <0.00%> (+1.00%)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `74.60% <0.00%> (+3.17%)` | `14.00% <0.00%> (ø%)` | |
| [...master/dispatch/executor/NettyExecutorManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9leGVjdXRvci9OZXR0eUV4ZWN1dG9yTWFuYWdlci5qYXZh) | `83.92% <0.00%> (+8.06%)` | `10.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730?src=pr&el=footer). Last update [1771aa5...878204f](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org