You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "tm_jee (JIRA)" <ji...@apache.org> on 2006/05/12 10:12:32 UTC

[jira] Created: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

url validator does not work as expected (client and server side) under some circumstances
-----------------------------------------------------------------------------------------

         Key: WW-1311
         URL: http://issues.apache.org/struts/browse/WW-1311
     Project: Struts Action 2
        Type: Bug

    Versions: WW 2.2.2    
    Reporter: tm_jee
 Assigned to: tm_jee 
     Fix For: 2.0


see http://forums.opensymphony.com/thread.jspa?threadID=30171&tstart=0 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "tm_jee (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/struts/browse/WW-1311?page=comments#action_37345 ] 

tm_jee commented on WW-1311:
----------------------------

the discussion on when to cut a 2.2.3 release is discussed at http://forums.opensymphony.com/thread.jspa?threadID=30435&tstart=0

> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?messageID=59066 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "tm_jee (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/struts/browse/WW-1311?page=comments#action_37342 ] 

tm_jee commented on WW-1311:
----------------------------

can't seems to commit into apache svn, will try later.

> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?threadID=30171&tstart=0 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "tm_jee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/WW-1311?page=all ]
     
tm_jee resolved WW-1311:
------------------------

    Resolution: Fixed

> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?messageID=59066 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "tm_jee (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/struts/browse/WW-1311?page=comments#action_37344 ] 

tm_jee commented on WW-1311:
----------------------------

most probably not, cause it's i believe lock. But I think we would backport some of the issues to WW and do a 2.2.3 release, depending on when that's being planned, currently still waiting for Pat or Rainer to make that call. The issues to be backported are discuss at http://forums.opensymphony.com/thread.jspa?threadID=29771&tstart=0

> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?messageID=59066 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "tm_jee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/WW-1311?page=all ]

tm_jee updated WW-1311:
-----------------------

    Description: see http://forums.opensymphony.com/thread.jspa?messageID=59066 for more info  (was: see http://forums.opensymphony.com/thread.jspa?threadID=30171&tstart=0 for more info)

> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?messageID=59066 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "tm_jee (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/struts/browse/WW-1311?page=comments#action_37341 ] 

tm_jee commented on WW-1311:
----------------------------

corrected the regexp for client-side validation, its now

(^(ftp|http|https):\/\/(\.[_A-Za-z0-9-]+)*(@?([A-Za-z0-9-])+)?(\.[A-Za-z0-9-]+)*((\.[A-Za-z0-9]{2,})|(\.[A-Za-z0-9]{2,}\.[A-Za-z0-9]{2,}))(:[0-9]+)?([/A-Za-z0-9?#_-]*)?$)

it should validate (at the client-side) ok now.

As for the server side, OSCore TextUtils.verifyUrl(String) is using java's URL(...) to determine it the url is ok. It seems that "http://www.jroller.com1/qwe?qwe (domen - com1)"

is being treated as java's URL object as a valid url, hence no MalformURLException is thrown. I don't think there's much we could do unless we don't rely on oscore's TextUtils.verifyUrl(String) and parse it in UrlValidator using regular expression.



> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?threadID=30171&tstart=0 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "Schava Eugene (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/struts/browse/WW-1311?page=comments#action_37343 ] 

Schava Eugene commented on WW-1311:
-----------------------------------

Toby, would you commit this into ww repository?

> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?messageID=59066 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "tm_jee (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/struts/browse/WW-1311?page=comments#action_37341 ] 

tm_jee commented on WW-1311:
----------------------------

corrected the regexp for client-side validation, its now

(^(ftp|http|https):\/\/(\.[_A-Za-z0-9-]+)*(@?([A-Za-z0-9-])+)?(\.[A-Za-z0-9-]+)*((\.[A-Za-z0-9]{2,})|(\.[A-Za-z0-9]{2,}\.[A-Za-z0-9]{2,}))(:[0-9]+)?([/A-Za-z0-9?#_-]*)?$)

it should validate (at the client-side) ok now.

As for the server side, OSCore TextUtils.verifyUrl(String) is using java's URL(...) to determine it the url is ok. It seems that "http://www.jroller.com1/qwe?qwe (domen - com1)"

is being treated as java's URL object as a valid url, hence no MalformURLException is thrown. I don't think there's much we could do unless we don't rely on oscore's TextUtils.verifyUrl(String) and parse it in UrlValidator using regular expression.



> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?threadID=30171&tstart=0 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "tm_jee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/WW-1311?page=all ]

tm_jee updated WW-1311:
-----------------------

    Description: see http://forums.opensymphony.com/thread.jspa?messageID=59066 for more info  (was: see http://forums.opensymphony.com/thread.jspa?threadID=30171&tstart=0 for more info)

> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?messageID=59066 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "tm_jee (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/struts/browse/WW-1311?page=comments#action_37342 ] 

tm_jee commented on WW-1311:
----------------------------

can't seems to commit into apache svn, will try later.

> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?threadID=30171&tstart=0 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "tm_jee (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/struts/browse/WW-1311?page=comments#action_37345 ] 

tm_jee commented on WW-1311:
----------------------------

the discussion on when to cut a 2.2.3 release is discussed at http://forums.opensymphony.com/thread.jspa?threadID=30435&tstart=0

> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?messageID=59066 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "Schava Eugene (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/struts/browse/WW-1311?page=comments#action_37343 ] 

Schava Eugene commented on WW-1311:
-----------------------------------

Toby, would you commit this into ww repository?

> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?messageID=59066 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "tm_jee (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/struts/browse/WW-1311?page=comments#action_37344 ] 

tm_jee commented on WW-1311:
----------------------------

most probably not, cause it's i believe lock. But I think we would backport some of the issues to WW and do a 2.2.3 release, depending on when that's being planned, currently still waiting for Pat or Rainer to make that call. The issues to be backported are discuss at http://forums.opensymphony.com/thread.jspa?threadID=29771&tstart=0

> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?messageID=59066 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (WW-1311) url validator does not work as expected (client and server side) under some circumstances

Posted by "tm_jee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/WW-1311?page=all ]
     
tm_jee resolved WW-1311:
------------------------

    Resolution: Fixed

> url validator does not work as expected (client and server side) under some circumstances
> -----------------------------------------------------------------------------------------
>
>          Key: WW-1311
>          URL: http://issues.apache.org/struts/browse/WW-1311
>      Project: Struts Action 2
>         Type: Bug

>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0

>
> see http://forums.opensymphony.com/thread.jspa?messageID=59066 for more info

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira