[jira] [Work logged] (COLLECTIONS-737) The test FluentIterableTest.size should be splitted

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/COLLECTIONS-737?focusedWorklogId=350066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-350066 ]

ASF GitHub Bot logged work on COLLECTIONS-737:
----------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Nov/19 21:52
            Start Date: 26/Nov/19 21:52
    Worklog Time Spent: 10m 
      Work Description: Prodigysov commented on pull request #120: COLLECTIONS-737: The test FluentIterableTest.size should be splitted
URL: https://github.com/apache/commons-collections/pull/120
 
 
   Extracted the first part of FluentIterableTest.size to a sperate test FluentIterableTest.ofNull
   
   Fixes [COLLECTIONS-737](https://issues.apache.org/jira/browse/COLLECTIONS-737)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 350066)
    Remaining Estimate: 0h
            Time Spent: 10m

> The test FluentIterableTest.size should be splitted
> ---------------------------------------------------
>
>                 Key: COLLECTIONS-737
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-737
>             Project: Commons Collections
>          Issue Type: Test
>          Components: Collection
>            Reporter: Pengyu Nie
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The first part of FluentIterableTest.size is not testing function
> FluentIterable.size (see code copied below). Actually,
> FluentIterable.size will not be invoked at all, because
> FluentIterable.of(null) will throw an NPE before that. This part
> should be extracted as a separate unit test like
> FluentIterableTest.ofNull.
> {code:java}
> try {
>     FluentIterable.of((Iterable<?>) null).size();
>     fail("expecting NullPointerException");
> } catch (final NullPointerException npe) {
>     // expected
> }{code}
> I'll create a pull request for this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)