You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2019/06/19 20:54:45 UTC

[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #239: Fixes OVC on elements of complex type

olabusayoT commented on a change in pull request #239: Fixes OVC on elements of complex type
URL: https://github.com/apache/incubator-daffodil/pull/239#discussion_r295519675
 
 

 ##########
 File path: daffodil-test/src/test/resources/org/apache/daffodil/section17/calc_value_properties/outputValueCalc.tdml
 ##########
 @@ -708,4 +742,63 @@
 	    </tdml:errors>
 
 	</tdml:unparserTestCase>
+
+    <tdml:unparserTestCase name="refSimpleTypeElemWithOvc"
 
 Review comment:
   I went with unparserTestCase since we're dealing with testing outputValueCalcs and I only cared about the results of unparsing the provided infoset (i.e roundTrip='false') and triggering the OVC code path, and not the results of parsing. Also for consistency,  since the only tests in the file are unparserTestCase.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services