You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Alan Conway <ac...@redhat.com> on 2013/12/05 21:11:20 UTC
Re: Review Request 16018: QPID-5398: qpidd --acl-file does not work with a
drive-prefixed path on windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16018/
-----------------------------------------------------------
(Updated Dec. 5, 2013, 8:11 p.m.)
Review request for qpid, Andrew Stitcher, Justin Ross, and Steve Huston.
Changes
-------
Made this a separte JIRA and fixed the problem Andrew pointed out. I'd like to put this in 0.26.
Summary (updated)
-----------------
QPID-5398: qpidd --acl-file does not work with a drive-prefixed path on windows.
Bugs: QPID-5307
https://issues.apache.org/jira/browse/QPID-5307
Repository: qpid
Description (updated)
-------
QPID-5398: qpidd --acl-file does not work with a drive-prefixed path on windows.
On windows, acl-file was not recognizing drive-prefixed paths (e.g. c:\foo)
as absolute and was trying to interpret them relative to the brokers data-dir.
This commit fixes the problem and adds a general-purpose Path class that can be
a collection point for any other path-related portability problems that come up.
Diffs (updated)
-----
/trunk/qpid/cpp/src/CMakeLists.txt 1548180
/trunk/qpid/cpp/src/qpid/acl/AclPlugin.cpp 1548180
/trunk/qpid/cpp/src/qpid/sys/Path.h PRE-CREATION
/trunk/qpid/cpp/src/qpid/sys/posix/Path.cpp PRE-CREATION
/trunk/qpid/cpp/src/qpid/sys/windows/Path.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/16018/diff/
Testing
-------
Thanks,
Alan Conway
Re: Review Request 16018: QPID-5398: qpidd --acl-file does not work with a
drive-prefixed path on windows.
Posted by Alan Conway <ac...@redhat.com>.
> On Dec. 5, 2013, 8:20 p.m., Andrew Stitcher wrote:
> > /trunk/qpid/cpp/src/qpid/sys/posix/Path.cpp, line 40
> > <https://reviews.apache.org/r/16018/diff/2/?file=394493#file394493line40>
> >
> > Being nitpicky:
> >
> > I think it's more usual to have a message like:
> >
> > <context info>: strerror(errno)
> > (certainly perror() does this)
> >
> > Also "invalid path" is ambiguous, how about:
> >
> > string("stat() failed: ") + path + ": " + strError(errno)
> >
> > [And also for the windows version]
done.
- Alan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16018/#review29831
-----------------------------------------------------------
On Dec. 5, 2013, 8:11 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16018/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2013, 8:11 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Justin Ross, and Steve Huston.
>
>
> Bugs: QPID-5307
> https://issues.apache.org/jira/browse/QPID-5307
>
>
> Repository: qpid
>
>
> Description
> -------
>
> QPID-5398: qpidd --acl-file does not work with a drive-prefixed path on windows.
>
> On windows, acl-file was not recognizing drive-prefixed paths (e.g. c:\foo)
> as absolute and was trying to interpret them relative to the brokers data-dir.
>
> This commit fixes the problem and adds a general-purpose Path class that can be
> a collection point for any other path-related portability problems that come up.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/CMakeLists.txt 1548180
> /trunk/qpid/cpp/src/qpid/acl/AclPlugin.cpp 1548180
> /trunk/qpid/cpp/src/qpid/sys/Path.h PRE-CREATION
> /trunk/qpid/cpp/src/qpid/sys/posix/Path.cpp PRE-CREATION
> /trunk/qpid/cpp/src/qpid/sys/windows/Path.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16018/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alan Conway
>
>
Re: Review Request 16018: QPID-5398: qpidd --acl-file does not work with a
drive-prefixed path on windows.
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16018/#review29831
-----------------------------------------------------------
Ship it!
Except for the nit picking below this is good to go
/trunk/qpid/cpp/src/qpid/sys/posix/Path.cpp
<https://reviews.apache.org/r/16018/#comment57309>
Being nitpicky:
I think it's more usual to have a message like:
<context info>: strerror(errno)
(certainly perror() does this)
Also "invalid path" is ambiguous, how about:
string("stat() failed: ") + path + ": " + strError(errno)
[And also for the windows version]
- Andrew Stitcher
On Dec. 5, 2013, 8:11 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16018/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2013, 8:11 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Justin Ross, and Steve Huston.
>
>
> Bugs: QPID-5307
> https://issues.apache.org/jira/browse/QPID-5307
>
>
> Repository: qpid
>
>
> Description
> -------
>
> QPID-5398: qpidd --acl-file does not work with a drive-prefixed path on windows.
>
> On windows, acl-file was not recognizing drive-prefixed paths (e.g. c:\foo)
> as absolute and was trying to interpret them relative to the brokers data-dir.
>
> This commit fixes the problem and adds a general-purpose Path class that can be
> a collection point for any other path-related portability problems that come up.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/CMakeLists.txt 1548180
> /trunk/qpid/cpp/src/qpid/acl/AclPlugin.cpp 1548180
> /trunk/qpid/cpp/src/qpid/sys/Path.h PRE-CREATION
> /trunk/qpid/cpp/src/qpid/sys/posix/Path.cpp PRE-CREATION
> /trunk/qpid/cpp/src/qpid/sys/windows/Path.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16018/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alan Conway
>
>