You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by ciarancourtney <gi...@git.apache.org> on 2016/12/20 12:03:00 UTC

[GitHub] thrift pull request #1142: THRIFT-4009: Use @implementer instead of implemen...

GitHub user ciarancourtney opened a pull request:

    https://github.com/apache/thrift/pull/1142

    THRIFT-4009: Use @implementer instead of implements in TTwisted.py

    * As per zope.interface 4.0.0 changelog
    Deprecate the \u201cclass advice\u201d APIs from zope.interface.declarations: implements, implementsOnly, and classProvides. In their place, prefer the equivalent class decorators: @implementer, @implementer_only, and @provider. Code which uses the deprecated APIs will not work as expected under Py3k.
    https://pypi.python.org/pypi/zope.interface
    
    Patch is simply output of zope-2to3 -wn lib/py/src/transport/TTwisted.py
    
    All tests passed incl cross lang suite. Should be py2/3 compat

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ciarancourtney/thrift THRIFT-4009-use-implementer-decorator

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1142
    
----
commit 121be3b5f8319bd6cb3421a850c04652105a7add
Author: ciarancourtney <ci...@cylon.com>
Date:   2016-12-20T11:12:15Z

    THRIFT-4009: Use @implementer instead of implements in TTwisted.py
    * As per zope.interface 4.0.0 changelog
    Deprecate the \u201cclass advice\u201d APIs from zope.interface.declarations: implements, implementsOnly, and classProvides. In their place, prefer the equivalent class decorators: @implementer, @implementer_only, and @provider. Code which uses the deprecated APIs will not work as expected under Py3k.
    https://pypi.python.org/pypi/zope.interface
    
    Patch is simply output of zope-2to3 -wn lib/py/src/transport/TTwisted.py

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1142: THRIFT-4009: Use @implementer instead of implemen...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1142


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---