You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/03 01:34:33 UTC

[GitHub] [spark] panbingkun commented on a diff in pull request #37058: [SPARK-39661][CORE][SHUFFLE][SQL] Avoid creating unnecessary SLF4J Logger

panbingkun commented on code in PR #37058:
URL: https://github.com/apache/spark/pull/37058#discussion_r912417783


##########
core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala:
##########
@@ -56,7 +56,7 @@ private[spark] class NettyBlockTransferService(
     _port: Int,
     numCores: Int,
     driverEndPointRef: RpcEndpointRef = null)
-  extends BlockTransferService {
+  extends BlockTransferService with Logging {
 

Review Comment:
   "with Logging" is more consistent and natural here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org