You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <js...@apache.org> on 2016/01/26 20:08:54 UTC
Review Request 42816: Remove deprecated `HealthCheckConfig` fields.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
Bugs: AURORA-1563
https://issues.apache.org/jira/browse/AURORA-1563
Repository: aurora
Description
-------
Remove `endpoint`, `expected_response` and `expected_response_code`
which were all deprecated in Aurora 0.11.0 in favor of the same-named
fields in `HttpHealthChecker`.
This also removes health check validaion in the client in favor of
leveraging the pystachio schema. The one difference this allows for is
an empty string for the `ShellHealthChecker.shell_command`. Since an
empty string is a valid shell command (equivalent to `true`), this
simplification seems justified.
NEWS | 3 ++
docs/configuration-reference.md | 3 --
src/main/python/apache/aurora/client/config.py | 31 ------------------
src/main/python/apache/aurora/config/schema/base.py | 5 +--
src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
6 files changed, 9 insertions(+), 138 deletions(-)
Diffs
-----
NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
Diff: https://reviews.apache.org/r/42816/diff/
Testing
-------
Locally green:
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by John Sirois <js...@apache.org>.
> On Jan. 26, 2016, 12:24 p.m., Dmitriy Shirchenko wrote:
> > src/test/python/apache/aurora/client/test_config.py, lines 213-223
> > <https://reviews.apache.org/r/42816/diff/1/?file=1221724#file1221724line213>
> >
> > this test is still relevant though, no? you still need to validate that only one type was specified and make sure we don't default to one w/out giving feedback to the user. this is expected to be a pystachio error.
Well - the check is just a type-check, which pystachio already does for all fields, ie - can't pass 1 to a String field, etc. So it seemed like a test of pystachio at this point, which does not belong here.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/#review116419
-----------------------------------------------------------
On Jan. 26, 2016, 12:26 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42816/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 12:26 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1552 and AURORA-1563
> https://issues.apache.org/jira/browse/AURORA-1552
> https://issues.apache.org/jira/browse/AURORA-1563
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove `endpoint`, `expected_response` and `expected_response_code`
> which were all deprecated in Aurora 0.11.0 in favor of the same-named
> fields in `HttpHealthChecker`.
>
> This also removes health check validation in the client in favor of
> leveraging the pystachio schema. The one difference this allows for is
> an empty string for the `ShellHealthChecker.shell_command`. Since an
> empty string is a valid shell command (equivalent to `true`), this
> simplification seems justified.
>
> NEWS | 3 ++
> docs/configuration-reference.md | 3 --
> src/main/python/apache/aurora/client/config.py | 31 ------------------
> src/main/python/apache/aurora/config/schema/base.py | 5 +--
> src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
> src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
> 6 files changed, 9 insertions(+), 138 deletions(-)
>
>
> Diffs
> -----
>
> NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
> docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
> src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
> src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
> src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
> src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
>
> Diff: https://reviews.apache.org/r/42816/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by John Sirois <js...@apache.org>.
> On Jan. 26, 2016, 12:24 p.m., Dmitriy Shirchenko wrote:
> > src/test/python/apache/aurora/client/test_config.py, lines 213-223
> > <https://reviews.apache.org/r/42816/diff/1/?file=1221724#file1221724line213>
> >
> > this test is still relevant though, no? you still need to validate that only one type was specified and make sure we don't default to one w/out giving feedback to the user. this is expected to be a pystachio error.
>
> John Sirois wrote:
> Well - the check is just a type-check, which pystachio already does for all fields, ie - can't pass 1 to a String field, etc. So it seemed like a test of pystachio at this point, which does not belong here.
>
> John Sirois wrote:
> Re-reading your comment though, a check that `HealthCheckerConfig` has exactly one of its fields (`http` or `shell`) populated might be a worthwhile check. That said - the check did not exist in this file before afaict.
> I'll re-open the issue pending your response.
>
> John Sirois wrote:
> OK - dropping the issue given your ship, but this does seem like a pre-existing bug or else missing feature; ie failing if both `http` and `shell` are set since only 1 - `shell` will be used in this case.
> In other words, what we ideally want for `HealthCheckerConfig` is a single union field (if pystachio supported `Union(A, B, ... Z)`), or - better - `Job.health_check_config` defined as a union field.
> If I've described this correctly I'll open a seperate issue for a seperate release that adds that sort of check one way or the other.
>
> Dmitriy Shirchenko wrote:
> Yea, I tried writing one but it got complicated with two ways of defining http based health check. It will be more straightforward to write one now. I think it's worthwhile to add more safeguards, being someone who makes a lot of config mistakes.
OK - filed https://issues.apache.org/jira/browse/AURORA-1599 for that.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/#review116419
-----------------------------------------------------------
On Jan. 26, 2016, 12:26 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42816/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 12:26 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1552 and AURORA-1563
> https://issues.apache.org/jira/browse/AURORA-1552
> https://issues.apache.org/jira/browse/AURORA-1563
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove `endpoint`, `expected_response` and `expected_response_code`
> which were all deprecated in Aurora 0.11.0 in favor of the same-named
> fields in `HttpHealthChecker`.
>
> This also removes health check validation in the client in favor of
> leveraging the pystachio schema. The one difference this allows for is
> an empty string for the `ShellHealthChecker.shell_command`. Since an
> empty string is a valid shell command (equivalent to `true`), this
> simplification seems justified.
>
> NEWS | 3 ++
> docs/configuration-reference.md | 3 --
> src/main/python/apache/aurora/client/config.py | 31 ------------------
> src/main/python/apache/aurora/config/schema/base.py | 5 +--
> src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
> src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
> 6 files changed, 9 insertions(+), 138 deletions(-)
>
>
> Diffs
> -----
>
> NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
> docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
> src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
> src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
> src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
> src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
>
> Diff: https://reviews.apache.org/r/42816/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by John Sirois <js...@apache.org>.
> On Jan. 26, 2016, 12:24 p.m., Dmitriy Shirchenko wrote:
> > src/test/python/apache/aurora/client/test_config.py, lines 213-223
> > <https://reviews.apache.org/r/42816/diff/1/?file=1221724#file1221724line213>
> >
> > this test is still relevant though, no? you still need to validate that only one type was specified and make sure we don't default to one w/out giving feedback to the user. this is expected to be a pystachio error.
>
> John Sirois wrote:
> Well - the check is just a type-check, which pystachio already does for all fields, ie - can't pass 1 to a String field, etc. So it seemed like a test of pystachio at this point, which does not belong here.
Re-reading your comment though, a check that `HealthCheckerConfig` has exactly one of its fields (`http` or `shell`) populated might be a worthwhile check. That said - the check did not exist in this file before afaict.
I'll re-open the issue pending your response.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/#review116419
-----------------------------------------------------------
On Jan. 26, 2016, 12:26 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42816/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 12:26 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1552 and AURORA-1563
> https://issues.apache.org/jira/browse/AURORA-1552
> https://issues.apache.org/jira/browse/AURORA-1563
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove `endpoint`, `expected_response` and `expected_response_code`
> which were all deprecated in Aurora 0.11.0 in favor of the same-named
> fields in `HttpHealthChecker`.
>
> This also removes health check validation in the client in favor of
> leveraging the pystachio schema. The one difference this allows for is
> an empty string for the `ShellHealthChecker.shell_command`. Since an
> empty string is a valid shell command (equivalent to `true`), this
> simplification seems justified.
>
> NEWS | 3 ++
> docs/configuration-reference.md | 3 --
> src/main/python/apache/aurora/client/config.py | 31 ------------------
> src/main/python/apache/aurora/config/schema/base.py | 5 +--
> src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
> src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
> 6 files changed, 9 insertions(+), 138 deletions(-)
>
>
> Diffs
> -----
>
> NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
> docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
> src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
> src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
> src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
> src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
>
> Diff: https://reviews.apache.org/r/42816/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by John Sirois <js...@apache.org>.
> On Jan. 26, 2016, 12:24 p.m., Dmitriy Shirchenko wrote:
> > src/test/python/apache/aurora/client/test_config.py, lines 213-223
> > <https://reviews.apache.org/r/42816/diff/1/?file=1221724#file1221724line213>
> >
> > this test is still relevant though, no? you still need to validate that only one type was specified and make sure we don't default to one w/out giving feedback to the user. this is expected to be a pystachio error.
>
> John Sirois wrote:
> Well - the check is just a type-check, which pystachio already does for all fields, ie - can't pass 1 to a String field, etc. So it seemed like a test of pystachio at this point, which does not belong here.
>
> John Sirois wrote:
> Re-reading your comment though, a check that `HealthCheckerConfig` has exactly one of its fields (`http` or `shell`) populated might be a worthwhile check. That said - the check did not exist in this file before afaict.
> I'll re-open the issue pending your response.
OK - dropping the issue given your ship, but this does seem like a pre-existing bug or else missing feature; ie failing if both `http` and `shell` are set since only 1 - `shell` will be used in this case.
In other words, what we ideally want for `HealthCheckerConfig` is a single union field (if pystachio supported `Union(A, B, ... Z)`), or - better - `Job.health_check_config` defined as a union field.
If I've described this correctly I'll open a seperate issue for a seperate release that adds that sort of check one way or the other.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/#review116419
-----------------------------------------------------------
On Jan. 26, 2016, 12:26 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42816/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 12:26 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1552 and AURORA-1563
> https://issues.apache.org/jira/browse/AURORA-1552
> https://issues.apache.org/jira/browse/AURORA-1563
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove `endpoint`, `expected_response` and `expected_response_code`
> which were all deprecated in Aurora 0.11.0 in favor of the same-named
> fields in `HttpHealthChecker`.
>
> This also removes health check validation in the client in favor of
> leveraging the pystachio schema. The one difference this allows for is
> an empty string for the `ShellHealthChecker.shell_command`. Since an
> empty string is a valid shell command (equivalent to `true`), this
> simplification seems justified.
>
> NEWS | 3 ++
> docs/configuration-reference.md | 3 --
> src/main/python/apache/aurora/client/config.py | 31 ------------------
> src/main/python/apache/aurora/config/schema/base.py | 5 +--
> src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
> src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
> 6 files changed, 9 insertions(+), 138 deletions(-)
>
>
> Diffs
> -----
>
> NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
> docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
> src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
> src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
> src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
> src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
>
> Diff: https://reviews.apache.org/r/42816/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
> On Jan. 26, 2016, 7:24 p.m., Dmitriy Shirchenko wrote:
> > src/test/python/apache/aurora/client/test_config.py, lines 213-223
> > <https://reviews.apache.org/r/42816/diff/1/?file=1221724#file1221724line213>
> >
> > this test is still relevant though, no? you still need to validate that only one type was specified and make sure we don't default to one w/out giving feedback to the user. this is expected to be a pystachio error.
>
> John Sirois wrote:
> Well - the check is just a type-check, which pystachio already does for all fields, ie - can't pass 1 to a String field, etc. So it seemed like a test of pystachio at this point, which does not belong here.
>
> John Sirois wrote:
> Re-reading your comment though, a check that `HealthCheckerConfig` has exactly one of its fields (`http` or `shell`) populated might be a worthwhile check. That said - the check did not exist in this file before afaict.
> I'll re-open the issue pending your response.
>
> John Sirois wrote:
> OK - dropping the issue given your ship, but this does seem like a pre-existing bug or else missing feature; ie failing if both `http` and `shell` are set since only 1 - `shell` will be used in this case.
> In other words, what we ideally want for `HealthCheckerConfig` is a single union field (if pystachio supported `Union(A, B, ... Z)`), or - better - `Job.health_check_config` defined as a union field.
> If I've described this correctly I'll open a seperate issue for a seperate release that adds that sort of check one way or the other.
Yea, I tried writing one but it got complicated with two ways of defining http based health check. It will be more straightforward to write one now. I think it's worthwhile to add more safeguards, being someone who makes a lot of config mistakes.
- Dmitriy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/#review116419
-----------------------------------------------------------
On Jan. 26, 2016, 7:26 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42816/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:26 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1552 and AURORA-1563
> https://issues.apache.org/jira/browse/AURORA-1552
> https://issues.apache.org/jira/browse/AURORA-1563
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove `endpoint`, `expected_response` and `expected_response_code`
> which were all deprecated in Aurora 0.11.0 in favor of the same-named
> fields in `HttpHealthChecker`.
>
> This also removes health check validation in the client in favor of
> leveraging the pystachio schema. The one difference this allows for is
> an empty string for the `ShellHealthChecker.shell_command`. Since an
> empty string is a valid shell command (equivalent to `true`), this
> simplification seems justified.
>
> NEWS | 3 ++
> docs/configuration-reference.md | 3 --
> src/main/python/apache/aurora/client/config.py | 31 ------------------
> src/main/python/apache/aurora/config/schema/base.py | 5 +--
> src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
> src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
> 6 files changed, 9 insertions(+), 138 deletions(-)
>
>
> Diffs
> -----
>
> NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
> docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
> src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
> src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
> src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
> src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
>
> Diff: https://reviews.apache.org/r/42816/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/#review116419
-----------------------------------------------------------
src/test/python/apache/aurora/client/test_config.py
<https://reviews.apache.org/r/42816/#comment177437>
this test is still relevant though, no? you still need to validate that only one type was specified and make sure we don't default to one w/out giving feedback to the user. this is expected to be a pystachio error.
- Dmitriy Shirchenko
On Jan. 26, 2016, 7:13 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42816/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:13 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1552 and AURORA-1563
> https://issues.apache.org/jira/browse/AURORA-1552
> https://issues.apache.org/jira/browse/AURORA-1563
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove `endpoint`, `expected_response` and `expected_response_code`
> which were all deprecated in Aurora 0.11.0 in favor of the same-named
> fields in `HttpHealthChecker`.
>
> This also removes health check validation in the client in favor of
> leveraging the pystachio schema. The one difference this allows for is
> an empty string for the `ShellHealthChecker.shell_command`. Since an
> empty string is a valid shell command (equivalent to `true`), this
> simplification seems justified.
>
> NEWS | 3 ++
> docs/configuration-reference.md | 3 --
> src/main/python/apache/aurora/client/config.py | 31 ------------------
> src/main/python/apache/aurora/config/schema/base.py | 5 +--
> src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
> src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
> 6 files changed, 9 insertions(+), 138 deletions(-)
>
>
> Diffs
> -----
>
> NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
> docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
> src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
> src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
> src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
> src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
>
> Diff: https://reviews.apache.org/r/42816/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/#review116535
-----------------------------------------------------------
I'll submit this tomorrow ~noon PST and start cutting an 0.12.0 RC if I don't hear back from Maxim or Josh.
- John Sirois
On Jan. 26, 2016, 12:26 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42816/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 12:26 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1552 and AURORA-1563
> https://issues.apache.org/jira/browse/AURORA-1552
> https://issues.apache.org/jira/browse/AURORA-1563
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove `endpoint`, `expected_response` and `expected_response_code`
> which were all deprecated in Aurora 0.11.0 in favor of the same-named
> fields in `HttpHealthChecker`.
>
> This also removes health check validation in the client in favor of
> leveraging the pystachio schema. The one difference this allows for is
> an empty string for the `ShellHealthChecker.shell_command`. Since an
> empty string is a valid shell command (equivalent to `true`), this
> simplification seems justified.
>
> NEWS | 3 ++
> docs/configuration-reference.md | 3 --
> src/main/python/apache/aurora/client/config.py | 31 ------------------
> src/main/python/apache/aurora/config/schema/base.py | 5 +--
> src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
> src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
> 6 files changed, 9 insertions(+), 138 deletions(-)
>
>
> Diffs
> -----
>
> NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
> docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
> src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
> src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
> src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
> src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
>
> Diff: https://reviews.apache.org/r/42816/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/
-----------------------------------------------------------
(Updated Jan. 27, 2016, 1:15 p.m.)
Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
Changes
-------
Kill more unused cruft from health check config validation removal.
src/main/python/apache/aurora/client/config.py | 9 ---------
1 file changed, 9 deletions(-)
Bugs: AURORA-1552 and AURORA-1563
https://issues.apache.org/jira/browse/AURORA-1552
https://issues.apache.org/jira/browse/AURORA-1563
Repository: aurora
Description
-------
Remove `endpoint`, `expected_response` and `expected_response_code`
which were all deprecated in Aurora 0.11.0 in favor of the same-named
fields in `HttpHealthChecker`.
This also removes health check validation in the client in favor of
leveraging the pystachio schema. The one difference this allows for is
an empty string for the `ShellHealthChecker.shell_command`. Since an
empty string is a valid shell command (equivalent to `true`), this
simplification seems justified.
NEWS | 3 ++
docs/configuration-reference.md | 3 --
src/main/python/apache/aurora/client/config.py | 31 ------------------
src/main/python/apache/aurora/config/schema/base.py | 5 +--
src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
6 files changed, 9 insertions(+), 138 deletions(-)
Diffs (updated)
-----
NEWS 0e9f3b30dca5311530d7be41a5295994377dac3d
docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
Diff: https://reviews.apache.org/r/42816/diff/
Testing
-------
Locally green:
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/#review116429
-----------------------------------------------------------
Ship it!
Master (7ccd532) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 26, 2016, 7:26 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42816/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:26 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1552 and AURORA-1563
> https://issues.apache.org/jira/browse/AURORA-1552
> https://issues.apache.org/jira/browse/AURORA-1563
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove `endpoint`, `expected_response` and `expected_response_code`
> which were all deprecated in Aurora 0.11.0 in favor of the same-named
> fields in `HttpHealthChecker`.
>
> This also removes health check validation in the client in favor of
> leveraging the pystachio schema. The one difference this allows for is
> an empty string for the `ShellHealthChecker.shell_command`. Since an
> empty string is a valid shell command (equivalent to `true`), this
> simplification seems justified.
>
> NEWS | 3 ++
> docs/configuration-reference.md | 3 --
> src/main/python/apache/aurora/client/config.py | 31 ------------------
> src/main/python/apache/aurora/config/schema/base.py | 5 +--
> src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
> src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
> 6 files changed, 9 insertions(+), 138 deletions(-)
>
>
> Diffs
> -----
>
> NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
> docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
> src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
> src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
> src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
> src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
>
> Diff: https://reviews.apache.org/r/42816/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/#review116426
-----------------------------------------------------------
Ship it!
Fair enough.
- Dmitriy Shirchenko
On Jan. 26, 2016, 7:26 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42816/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:26 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1552 and AURORA-1563
> https://issues.apache.org/jira/browse/AURORA-1552
> https://issues.apache.org/jira/browse/AURORA-1563
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove `endpoint`, `expected_response` and `expected_response_code`
> which were all deprecated in Aurora 0.11.0 in favor of the same-named
> fields in `HttpHealthChecker`.
>
> This also removes health check validation in the client in favor of
> leveraging the pystachio schema. The one difference this allows for is
> an empty string for the `ShellHealthChecker.shell_command`. Since an
> empty string is a valid shell command (equivalent to `true`), this
> simplification seems justified.
>
> NEWS | 3 ++
> docs/configuration-reference.md | 3 --
> src/main/python/apache/aurora/client/config.py | 31 ------------------
> src/main/python/apache/aurora/config/schema/base.py | 5 +--
> src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
> src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
> 6 files changed, 9 insertions(+), 138 deletions(-)
>
>
> Diffs
> -----
>
> NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
> docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
> src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
> src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
> src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
> src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
>
> Diff: https://reviews.apache.org/r/42816/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/#review116613
-----------------------------------------------------------
Rebasing against master to fixup NEWS conflict before submitting.
- John Sirois
On Jan. 26, 2016, 12:26 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42816/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 12:26 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1552 and AURORA-1563
> https://issues.apache.org/jira/browse/AURORA-1552
> https://issues.apache.org/jira/browse/AURORA-1563
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove `endpoint`, `expected_response` and `expected_response_code`
> which were all deprecated in Aurora 0.11.0 in favor of the same-named
> fields in `HttpHealthChecker`.
>
> This also removes health check validation in the client in favor of
> leveraging the pystachio schema. The one difference this allows for is
> an empty string for the `ShellHealthChecker.shell_command`. Since an
> empty string is a valid shell command (equivalent to `true`), this
> simplification seems justified.
>
> NEWS | 3 ++
> docs/configuration-reference.md | 3 --
> src/main/python/apache/aurora/client/config.py | 31 ------------------
> src/main/python/apache/aurora/config/schema/base.py | 5 +--
> src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
> src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
> 6 files changed, 9 insertions(+), 138 deletions(-)
>
>
> Diffs
> -----
>
> NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
> docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
> src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
> src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
> src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
> src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
>
> Diff: https://reviews.apache.org/r/42816/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 12:26 p.m.)
Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
Changes
-------
Kill more unused cruft from health check config validation removal.
src/main/python/apache/aurora/client/config.py | 9 ---------
1 file changed, 9 deletions(-)
Bugs: AURORA-1552 and AURORA-1563
https://issues.apache.org/jira/browse/AURORA-1552
https://issues.apache.org/jira/browse/AURORA-1563
Repository: aurora
Description
-------
Remove `endpoint`, `expected_response` and `expected_response_code`
which were all deprecated in Aurora 0.11.0 in favor of the same-named
fields in `HttpHealthChecker`.
This also removes health check validation in the client in favor of
leveraging the pystachio schema. The one difference this allows for is
an empty string for the `ShellHealthChecker.shell_command`. Since an
empty string is a valid shell command (equivalent to `true`), this
simplification seems justified.
NEWS | 3 ++
docs/configuration-reference.md | 3 --
src/main/python/apache/aurora/client/config.py | 31 ------------------
src/main/python/apache/aurora/config/schema/base.py | 5 +--
src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
6 files changed, 9 insertions(+), 138 deletions(-)
Diffs (updated)
-----
NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
Diff: https://reviews.apache.org/r/42816/diff/
Testing
-------
Locally green:
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/#review116418
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Jan. 26, 2016, 11:13 a.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42816/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 11:13 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
>
>
> Bugs: AURORA-1552 and AURORA-1563
> https://issues.apache.org/jira/browse/AURORA-1552
> https://issues.apache.org/jira/browse/AURORA-1563
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove `endpoint`, `expected_response` and `expected_response_code`
> which were all deprecated in Aurora 0.11.0 in favor of the same-named
> fields in `HttpHealthChecker`.
>
> This also removes health check validation in the client in favor of
> leveraging the pystachio schema. The one difference this allows for is
> an empty string for the `ShellHealthChecker.shell_command`. Since an
> empty string is a valid shell command (equivalent to `true`), this
> simplification seems justified.
>
> NEWS | 3 ++
> docs/configuration-reference.md | 3 --
> src/main/python/apache/aurora/client/config.py | 31 ------------------
> src/main/python/apache/aurora/config/schema/base.py | 5 +--
> src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
> src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
> 6 files changed, 9 insertions(+), 138 deletions(-)
>
>
> Diffs
> -----
>
> NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
> docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
> src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
> src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
> src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
> src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
>
> Diff: https://reviews.apache.org/r/42816/diff/
>
>
> Testing
> -------
>
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 12:13 p.m.)
Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
Bugs: AURORA-1552 and AURORA-1563
https://issues.apache.org/jira/browse/AURORA-1552
https://issues.apache.org/jira/browse/AURORA-1563
Repository: aurora
Description (updated)
-------
Remove `endpoint`, `expected_response` and `expected_response_code`
which were all deprecated in Aurora 0.11.0 in favor of the same-named
fields in `HttpHealthChecker`.
This also removes health check validation in the client in favor of
leveraging the pystachio schema. The one difference this allows for is
an empty string for the `ShellHealthChecker.shell_command`. Since an
empty string is a valid shell command (equivalent to `true`), this
simplification seems justified.
NEWS | 3 ++
docs/configuration-reference.md | 3 --
src/main/python/apache/aurora/client/config.py | 31 ------------------
src/main/python/apache/aurora/config/schema/base.py | 5 +--
src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
6 files changed, 9 insertions(+), 138 deletions(-)
Diffs
-----
NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
Diff: https://reviews.apache.org/r/42816/diff/
Testing
-------
Locally green:
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
Re: Review Request 42816: Remove deprecated `HealthCheckConfig`
fields.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 12:11 p.m.)
Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
Bugs: AURORA-1552 and AURORA-1563
https://issues.apache.org/jira/browse/AURORA-1552
https://issues.apache.org/jira/browse/AURORA-1563
Repository: aurora
Description
-------
Remove `endpoint`, `expected_response` and `expected_response_code`
which were all deprecated in Aurora 0.11.0 in favor of the same-named
fields in `HttpHealthChecker`.
This also removes health check validaion in the client in favor of
leveraging the pystachio schema. The one difference this allows for is
an empty string for the `ShellHealthChecker.shell_command`. Since an
empty string is a valid shell command (equivalent to `true`), this
simplification seems justified.
NEWS | 3 ++
docs/configuration-reference.md | 3 --
src/main/python/apache/aurora/client/config.py | 31 ------------------
src/main/python/apache/aurora/config/schema/base.py | 5 +--
src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
src/test/python/apache/aurora/client/test_config.py | 88 --------------------------------------------------
6 files changed, 9 insertions(+), 138 deletions(-)
Diffs
-----
NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a
docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2
src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85
src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4
src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9
Diff: https://reviews.apache.org/r/42816/diff/
Testing
-------
Locally green:
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois