You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/21 07:46:28 UTC
[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #2487: [Feature][JDBC-connector] support Jdbc oracle
liugddx opened a new pull request, #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487#discussion_r950851193
##########
seatunnel-connectors-v2/connector-jdbc/pom.xml:
##########
@@ -48,6 +48,11 @@
<artifactId>postgresql</artifactId>
</dependency>
+ <dependency>
+ <groupId></groupId>
+ <artifactId>orac</artifactId>
Review Comment:
please check this
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oracle/OracleJdbcRowConverter.java:
##########
@@ -0,0 +1,31 @@
+/**
+ * Copyright @ 2022科大讯飞。 All rights reserved.
+ *
+ * @author: gdliu3
+ * @Date: 2022/8/20 16:27
+ */
Review Comment:
Use apache license？ please check this
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oracle/OracleTypeMapper.java:
##########
@@ -0,0 +1,100 @@
+/**
+ * Copyright @ 2022科大讯飞。 All rights reserved.
+ *
+ * @author: gdliu3
+ * @Date: 2022/8/20 16:28
+ */
Review Comment:
please check this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487#discussion_r951347111
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oracle/OracleTypeMapper.java:
##########
@@ -0,0 +1,100 @@
+/**
+ * Copyright @ 2022科大讯飞。 All rights reserved.
+ *
+ * @author: gdliu3
+ * @Date: 2022/8/20 16:28
+ */
Review Comment:
I have doubts about the license of this code, is this a company code or yours?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx closed pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
liugddx closed pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
URL: https://github.com/apache/incubator-seatunnel/pull/2487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487#issuecomment-1228294449
> > @liugddx why close this pr ？
>
> I forgot to rebase,The submission record is messed up
I will resubmit the pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487#discussion_r952112963
##########
pom.xml:
##########
@@ -302,6 +303,12 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>${oracle.version}</version>
+ </dependency>
Review Comment:
It's better add `<scope>provide</scope>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487#discussion_r950842930
##########
pom.xml:
##########
@@ -302,6 +303,12 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.noraui</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>${oracle.version}</version>
+ </dependency>
Review Comment:
why do you use `com.oracle.database.jdbc/ojdbc`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
ic4y commented on PR #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487#issuecomment-1228159113
@liugddx why close this pr ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487#issuecomment-1228285464
> @liugddx why close this pr ？
I forgot to rebase,The submission record is messed up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on a diff in pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
ic4y commented on code in PR #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487#discussion_r952472708
##########
seatunnel-e2e/seatunnel-flink-new-connector-e2e/src/test/java/org/apache/seatunnel/e2e/flink/oracle/FakeSourceToOracleIT.java:
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.e2e.flink.oracle;
+
+import org.apache.seatunnel.e2e.flink.FlinkContainer;
+import org.junit.Assert;
+import org.junit.Test;
+import org.testcontainers.containers.Container;
+
+import java.io.IOException;
+
+
+public class FakeSourceToOracleIT extends FlinkContainer {
+ @Test
+ @SuppressWarnings("magicnumber")
+ public void testFakeSourceToOracleSink() throws IOException, InterruptedException {
+ Container.ExecResult execResult = executeSeaTunnelFlinkJob("/oracle/fakesource_to_oracle.conf");
+ Assert.assertEquals(0, execResult.getExitCode());
Review Comment:
Need to test sink and source on flink and spark.
And need to check the data size and data type. Also need to test exactly-once mode if XA transaction are supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487#discussion_r950842930
##########
pom.xml:
##########
@@ -302,6 +303,12 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.noraui</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>${oracle.version}</version>
+ </dependency>
Review Comment:
why don't you use `com.oracle.database.jdbc/ojdbc`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487#discussion_r950842783
##########
pom.xml:
##########
@@ -302,6 +303,12 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.noraui</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>${oracle.version}</version>
+ </dependency>
Review Comment:
This doesn't seem to be an official driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
liugddx commented on code in PR #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487#discussion_r950968980
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oracle/OracleTypeMapper.java:
##########
@@ -0,0 +1,100 @@
+/**
+ * Copyright @ 2022科大讯飞。 All rights reserved.
+ *
+ * @author: gdliu3
+ * @Date: 2022/8/20 16:28
+ */
Review Comment:
I'm sorry,I'll change it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #2487: [Feature][JDBC-connector] support Jdbc oracle
Posted by GitBox <gi...@apache.org>.
liugddx commented on code in PR #2487:
URL: https://github.com/apache/incubator-seatunnel/pull/2487#discussion_r951545733
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oracle/OracleTypeMapper.java:
##########
@@ -0,0 +1,100 @@
+/**
+ * Copyright @ 2022科大讯飞。 All rights reserved.
+ *
+ * @author: gdliu3
+ * @Date: 2022/8/20 16:28
+ */
Review Comment:
>
This is my code,My ide automatically brings out comments,I forgot to replace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org