You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/08 03:58:02 UTC

[GitHub] [beam] robinyqiu commented on a change in pull request #12973: [BEAM-10234] Create ApproximateDistinct using HLL Impl

robinyqiu commented on a change in pull request #12973:
URL: https://github.com/apache/beam/pull/12973#discussion_r538015847



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateUnique.java
##########
@@ -56,7 +56,10 @@
  *
  * For more details about using {@code HllCount} and the {@code zetasketch} extension module, see
  * https://s.apache.org/hll-in-beam#bookmark=id.v6chsij1ixo7.
+ *
+ * @deprecated use {@code ApproximateCountDistinct} which has moved to HLL implementation.

Review comment:
       I am ok with that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org