You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by fuyou001 <gi...@git.apache.org> on 2017/09/13 04:27:18 UTC

[GitHub] incubator-rocketmq pull request #163: [ROCKETMQ-289] getBrokerRuntimeInfo me...

GitHub user fuyou001 opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/163

    [ROCKETMQ-289] getBrokerRuntimeInfo method output fileReservedTime value

    
    Motivation:
    add fileReservedTime value for getBrokerRuntimeInfo return   `runtimeInfo`
    
    Modification:
    getBrokerRuntimeInfo method add a key `fileReservedTimeByHour` mean fileReservedTime in `runtimeInfo`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fuyou001/incubator-rocketmq ROCKETMQ-289

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #163
    
----
commit c8079c3048c67b11ba9d78320a702be62aace523
Author: 傅冲 <yu...@alibaba-inc.com>
Date:   2017-09-13T01:57:01Z

    [ROCKETMQ-289] getBrokerRuntimeInfo method output fileReservedTime value

----


---

[GitHub] incubator-rocketmq issue #163: [ROCKETMQ-289] getBrokerRuntimeInfo method ou...

Posted by coveralls <gi...@git.apache.org>.

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/163
  
    
    [![Coverage Status](https://coveralls.io/builds/13246332/badge)](https://coveralls.io/builds/13246332)
    
    Coverage increased (+0.1%) to 38.851% when pulling **c8079c3048c67b11ba9d78320a702be62aace523 on fuyou001:ROCKETMQ-289** into **368e7c86a0b06099f336c81672112dcb5143cf9e on apache:develop**.



---

[GitHub] incubator-rocketmq issue #163: [ROCKETMQ-289] getBrokerRuntimeInfo method ou...

Posted by zhouxinyu <gi...@git.apache.org>.

Github user zhouxinyu commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/163
  
    Hi, thanks for your contribution. We could get FileReservedTime through `GetBrokerConfigCommand`, there is no need to add it to `runtimeInfo `.


---

[GitHub] incubator-rocketmq pull request #163: [ROCKETMQ-289] getBrokerRuntimeInfo me...

Posted by fuyou001 <gi...@git.apache.org>.

Github user fuyou001 closed the pull request at:

    https://github.com/apache/incubator-rocketmq/pull/163


---