You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2026/09/15 21:14:27 UTC

[Impala-ASF-CR] PEND: Add support for lld

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24858


Change subject: PEND: Add support for lld
......................................................................

PEND: Add support for lld

Adds support for using Clang 12's lld. Adds another LLVM version var,
which may not be necessary soon.

Change-Id: I09913c2551f17497546f91d506bf5bef4f47e292
---
M README-build.md
M be/CMakeLists.txt
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
M bin/run-backend-tests.sh
M bin/run-binary.sh
M bin/run-jvm-binary.sh
M bin/run_clang_tidy.sh
M cmake_modules/clang_toolchain.cmake
9 files changed, 32 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/24858/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09913c2551f17497546f91d506bf5bef4f47e292
Gerrit-Change-Number: 24858
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] PEND: Add support for lld

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24858 )

Change subject: PEND: Add support for lld
......................................................................


Patch Set 1:

(4 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run-backend-tests.sh
File bin/run-backend-tests.sh:

http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run-backend-tests.sh@41
PS1, Line 41: export PATH="${IMPALA_TOOLCHAIN_PACKAGES_HOME}/llvm-${IMPALA_LLVM_TOOLS_VERSION}/bin:${PATH}"
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run-binary.sh
File bin/run-binary.sh:

http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run-binary.sh@35
PS1, Line 35: export PATH="${IMPALA_TOOLCHAIN_PACKAGES_HOME}/llvm-${IMPALA_LLVM_TOOLS_VERSION}/bin:${PATH}"
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run-jvm-binary.sh
File bin/run-jvm-binary.sh:

http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run-jvm-binary.sh@39
PS1, Line 39: export PATH="${IMPALA_TOOLCHAIN_PACKAGES_HOME}/llvm-${IMPALA_LLVM_TOOLS_VERSION}/bin:${PATH}"
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run_clang_tidy.sh
File bin/run_clang_tidy.sh:

http://gerrit.cloudera.org:8080/#/c/24858/1/bin/run_clang_tidy.sh@61
PS1, Line 61: export PATH="${IMPALA_TOOLCHAIN_PACKAGES_HOME}/llvm-${IMPALA_LLVM_TOOLS_VERSION}/bin/:$PATH"
line too long (92 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/24858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09913c2551f17497546f91d506bf5bef4f47e292
Gerrit-Change-Number: 24858
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 21:16:42 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] PEND: Add support for lld

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24858 )

Change subject: PEND: Add support for lld
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/24042/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09913c2551f17497546f91d506bf5bef4f47e292
Gerrit-Change-Number: 24858
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 21:42:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] PEND: Add support for lld

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24858 )

Change subject: PEND: Add support for lld
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Build Failed 
> 
> https://jenkins.impala.io/job/gerrit-code-review-checks/24042/ : Initial code review checks failed. See linked job for details on the failure.

Clang 12 brings in some new tidy issues we'd need to address.


-- 
To view, visit http://gerrit.cloudera.org:8080/24858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I09913c2551f17497546f91d506bf5bef4f47e292
Gerrit-Change-Number: 24858
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 22:07:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] PEND: Add support for lld

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has abandoned this change. ( https://gerrit.cloudera.org/24858 )

Change subject: PEND: Add support for lld
......................................................................


Abandoned

Went with mold instead.
-- 
To view, visit https://gerrit.cloudera.org/24858
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I09913c2551f17497546f91d506bf5bef4f47e292
Gerrit-Change-Number: 24858
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>