You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by kamaci <gi...@git.apache.org> on 2016/06/21 21:05:10 UTC

[GitHub] nutch pull request #124: NUTCH-2284 Basic Authentication support for Nutch 2...

GitHub user kamaci opened a pull request:

    https://github.com/apache/nutch/pull/124

    NUTCH-2284 Basic Authentication support for Nutch 2.X REST API.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kamaci/nutch NUTCH-2284

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nutch/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #124
    
----
commit 52ffc5a983f261570fd25f10f2f8fcf70d543c88
Author: Furkan KAMACI <fu...@gmail.com>
Date:   2016-06-19T20:27:15Z

    NUTCH-2284 Basic Authentication support for Nutch 2.X REST API.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request #124: NUTCH-2284 Basic Authentication support for Nutch 2...

Posted by kamaci <gi...@git.apache.org>.
Github user kamaci commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/124#discussion_r69390563
  
    --- Diff: conf/nutch-default.xml ---
    @@ -1435,4 +1435,30 @@
       </description>
     </property>
     
    +<property>
    +  <name>restapi.auth</name>
    +  <value>false</value>
    +  <description>
    +    Whether to enable HTTP basic authentication for communicating with RESTAPI.
    +    Use the restapi.auth.username and restapi.auth.auth.password properties to configure
    --- End diff --
    
    @lewismc I've fixed typo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request #124: NUTCH-2284 Basic Authentication support for Nutch 2...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/124#discussion_r68629394
  
    --- Diff: conf/nutch-default.xml ---
    @@ -1435,4 +1435,30 @@
       </description>
     </property>
     
    +<property>
    +  <name>restapi.auth</name>
    +  <value>false</value>
    +  <description>
    +    Whether to enable HTTP basic authentication for communicating with RESTAPI.
    +    Use the restapi.auth.username and restapi.auth.auth.password properties to configure
    --- End diff --
    
    Typo in restapi.auth.auth.password it should be restapi.auth.password


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request #124: NUTCH-2284 Basic Authentication support for Nutch 2...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/124#discussion_r68629674
  
    --- Diff: src/java/org/apache/nutch/api/NutchServer.java ---
    @@ -85,7 +88,12 @@
        * well as the logging granularity. If the latter option is not provided via
        * {@link org.apache.nutch.api.NutchServer#main(String[])} then it defaults to
        * 'INFO' however best attempts should always be made to specify a logging
    -   * level.
    +   * level.<br>
    +   * {@link org.apache.nutch.api.NutchServer} can be run as secure. restapi.auth property
    +   * should be set to true at <code>nutch-site.xml</code> to enable HTTP basic authentication
    --- End diff --
    
    In JDK 1.8 I think the relevnt HTML encoding should be used e.g. &lt;code&gt;nutch-site.xml&lt;/code&gt;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request #124: NUTCH-2284 Basic Authentication support for Nutch 2...

Posted by kamaci <gi...@git.apache.org>.
Github user kamaci commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/124#discussion_r69391391
  
    --- Diff: src/java/org/apache/nutch/api/NutchServer.java ---
    @@ -85,7 +88,12 @@
        * well as the logging granularity. If the latter option is not provided via
        * {@link org.apache.nutch.api.NutchServer#main(String[])} then it defaults to
        * 'INFO' however best attempts should always be made to specify a logging
    -   * level.
    +   * level.<br>
    +   * {@link org.apache.nutch.api.NutchServer} can be run as secure. restapi.auth property
    +   * should be set to true at <code>nutch-site.xml</code> to enable HTTP basic authentication
    --- End diff --
    
    @lewismc does using &gt; and &lt; is enough? I couldn't see any documentation related to it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request #124: NUTCH-2284 Basic Authentication support for Nutch 2...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nutch/pull/124


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---