You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/03/05 20:51:59 UTC
[jira] [Commented] (HBASE-5521) Move compression/decompression to
an encoder specific encoding context
[ https://issues.apache.org/jira/browse/HBASE-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222555#comment-13222555 ]
jiraposter@reviews.apache.org commented on HBASE-5521:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4182/
-----------------------------------------------------------
Review request for hbase, Dhruba Borthakur and Scott Chen.
Summary
-------
Move compression/decompression to an encoder specific encoding context
This addresses bug HBASE-5521.
https://issues.apache.org/jira/browse/HBASE-5521
Diffs
-----
/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileDataBlockEncoder.java 1297201
/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileDataBlockEncoderImpl.java 1297201
/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java 1297201
/src/main/java/org/apache/hadoop/hbase/io/hfile/NoOpDataBlockEncoder.java 1296006
/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java 1297201
/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDecodingContext.java PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultDecodingContext.java PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultEncodingContext.java PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockEncodingContext.java PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java 1297201
/src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoding.java 1297201
/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java 1297201
/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java 1297201
/src/main/java/org/apache/hadoop/hbase/io/encoding/CopyKeyDataBlockEncoder.java 1297201
/src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java 1297201
/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlock.java 1297201
/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileDataBlockEncoder.java 1297201
/src/test/java/org/apache/hadoop/hbase/regionserver/DataBlockEncodingTool.java 1297201
Diff: https://reviews.apache.org/r/4182/diff
Testing
-------
Thanks,
Yongqiang
> Move compression/decompression to an encoder specific encoding context
> ----------------------------------------------------------------------
>
> Key: HBASE-5521
> URL: https://issues.apache.org/jira/browse/HBASE-5521
> Project: HBase
> Issue Type: Improvement
> Reporter: He Yongqiang
> Attachments: HBASE-5521.1.patch
>
>
> As part of working on HBASE-5313, we want to add a new columnar encoder/decoder. It makes sense to move compression to be part of encoder/decoder:
> 1) a scanner for a columnar encoded block can do lazy decompression to a specific part of a key value object
> 2) avoid an extra bytes copy from encoder to hblock-writer.
> If there is no encoder specified for a writer, the HBlock.Writer will use a default compression-context to do something very similar to today's code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira