You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by ec...@apache.org on 2015/02/10 20:25:15 UTC
accumulo git commit: ACCUMULO-3572 demote fileSize print to trace
Repository: accumulo
Updated Branches:
refs/heads/1.6 dc471efee -> ac44627eb
ACCUMULO-3572 demote fileSize print to trace
Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/ac44627e
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/ac44627e
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/ac44627e
Branch: refs/heads/1.6
Commit: ac44627eb57366cb935c4b735aca4998a744d435
Parents: dc471ef
Author: Eric C. Newton <er...@gmail.com>
Authored: Tue Feb 10 14:23:51 2015 -0500
Committer: Eric C. Newton <er...@gmail.com>
Committed: Tue Feb 10 14:23:51 2015 -0500
----------------------------------------------------------------------
.../java/org/apache/accumulo/server/util/TableDiskUsage.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/accumulo/blob/ac44627e/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
----------------------------------------------------------------------
diff --git a/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java b/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
index 9a54927..24eac05 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
@@ -96,7 +96,9 @@ public class TableDiskUsage {
Map<List<Integer>,Long> usage = new HashMap<List<Integer>,Long>();
for (Entry<String,Integer[]> entry : tableFiles.entrySet()) {
- log.info("fileSizes " + fileSizes + " key " + Arrays.asList(entry.getKey()));
+ if (log.isTraceEnabled()) {
+ log.trace("fileSizes " + fileSizes + " key " + entry.getKey());
+ }
List<Integer> key = Arrays.asList(entry.getValue());
Long size = fileSizes.get(entry.getKey());
Re: accumulo git commit: ACCUMULO-3572 demote fileSize print to trace
Posted by Keith Turner <ke...@deenlo.com>.
On Tue, Feb 10, 2015 at 2:25 PM, <ec...@apache.org> wrote:
> Repository: accumulo
> Updated Branches:
> refs/heads/1.6 dc471efee -> ac44627eb
>
>
> ACCUMULO-3572 demote fileSize print to trace
>
>
> Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
> Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/ac44627e
> Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/ac44627e
> Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/ac44627e
>
> Branch: refs/heads/1.6
> Commit: ac44627eb57366cb935c4b735aca4998a744d435
> Parents: dc471ef
> Author: Eric C. Newton <er...@gmail.com>
> Authored: Tue Feb 10 14:23:51 2015 -0500
> Committer: Eric C. Newton <er...@gmail.com>
> Committed: Tue Feb 10 14:23:51 2015 -0500
>
> ----------------------------------------------------------------------
> .../java/org/apache/accumulo/server/util/TableDiskUsage.java | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/accumulo/blob/ac44627e/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
> ----------------------------------------------------------------------
> diff --git
> a/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
> b/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
> index 9a54927..24eac05 100644
> ---
> a/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
> +++
> b/server/base/src/main/java/org/apache/accumulo/server/util/TableDiskUsage.java
> @@ -96,7 +96,9 @@ public class TableDiskUsage {
> Map<List<Integer>,Long> usage = new HashMap<List<Integer>,Long>();
>
> for (Entry<String,Integer[]> entry : tableFiles.entrySet()) {
> - log.info("fileSizes " + fileSizes + " key " +
> Arrays.asList(entry.getKey()));
> + if (log.isTraceEnabled()) {
> + log.trace("fileSizes " + fileSizes + " key " + entry.getKey());
> + }
>
Arrays usually have completely useless toString() methods. So going from
Arrays.asList(entry.getKey()).toString() to entry.getKey().toString().
will likely not print the Integer[] array contents
> List<Integer> key = Arrays.asList(entry.getValue());
> Long size = fileSizes.get(entry.getKey());
>
>
>