You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/08/08 20:58:57 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #7234: Minor: Move streams out of main physical_plan module
alamb opened a new pull request, #7234:
URL: https://github.com/apache/arrow-datafusion/pull/7234
## Which issue does this PR close?
Part of https://github.com/apache/arrow-datafusion/issues/1754
## Rationale for this change
As part of preparing (finally) to move the physical_plan into its own crate so datafusion builds faster and is more modular, I am doing some code rearranging to slim down the contents of `physical_plan/mod.rs`
## What changes are included in this PR?
1. Move `RecordBatchStream` and `SendableRecordBatchStream` to `datafusion_execution` crate
2. Move `EmptyStream` into `stream.rs` with other stream wrappers (so hopefully it will be more discoverable)
## Are these changes tested?
covered by existing tests
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
No: I left `pub use` so there should be no backwards incompatible changes
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #7234: Minor: Move streams out of `physical_plan` module
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7234:
URL: https://github.com/apache/arrow-datafusion/pull/7234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org