You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/11 11:56:48 UTC
[GitHub] [arrow] AlenkaF opened a new pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean
AlenkaF opened a new pull request #12401:
URL: https://github.com/apache/arrow/pull/12401
Add info about `make clean` to the building section of the New Contributor's Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12401:
URL: https://github.com/apache/arrow/pull/12401#issuecomment-1040680555
Benchmark runs are scheduled for baseline = cca3800bd95c4476f695cccf2bf9f39abacf4bf3 and contender = 3873f632952370688bfd087e0624f96f3d5b5b56. 3873f632952370688bfd087e0624f96f3d5b5b56 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/56547056e4004c21a8e0a426e97d5187...f5e63b7eeca64a128948fde8ec1ae219/)
[Finished :arrow_down:0.09% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fe240ea54c542d8918963d4704e702d...7cd1214fd23a4ab9adca085a645cd0ec/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6b3eb5d148714c0e86ce9d85df3558d4...09cbe88987e747aab2a459558aeb55d3/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d19cb70b0fde4c21bc02b1120755ded2...c55efbfdbea345309beec7ada00254d3/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12401:
URL: https://github.com/apache/arrow/pull/12401#issuecomment-1040680555
Benchmark runs are scheduled for baseline = cca3800bd95c4476f695cccf2bf9f39abacf4bf3 and contender = 3873f632952370688bfd087e0624f96f3d5b5b56. 3873f632952370688bfd087e0624f96f3d5b5b56 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/56547056e4004c21a8e0a426e97d5187...f5e63b7eeca64a128948fde8ec1ae219/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fe240ea54c542d8918963d4704e702d...7cd1214fd23a4ab9adca085a645cd0ec/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6b3eb5d148714c0e86ce9d85df3558d4...09cbe88987e747aab2a459558aeb55d3/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d19cb70b0fde4c21bc02b1120755ded2...c55efbfdbea345309beec7ada00254d3/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12401:
URL: https://github.com/apache/arrow/pull/12401#discussion_r805696971
##########
File path: docs/source/developers/guide/step_by_step/building.rst
##########
@@ -155,6 +155,22 @@ Building other Arrow libraries
`R developer docs <https://arrow.apache.org/docs/r/articles/developing.html>`_.
+ **Reinstalling R package and running 'make clean'**
+
+ When you will make changes to the Arrow C++ part of the code, also
+ called libarrow, you will need to:
+
+ #. reinstall libarrow,
+ #. run ``make clean``,
+ #. reinstall the R package.
+
+ The ``make clean`` function is defined in ``r/Makefile``. The file
Review comment:
```suggestion
The ``make clean`` function is defined in ``r/Makefile``. This file
```
##########
File path: docs/source/developers/guide/step_by_step/building.rst
##########
@@ -155,6 +155,22 @@ Building other Arrow libraries
`R developer docs <https://arrow.apache.org/docs/r/articles/developing.html>`_.
+ **Reinstalling R package and running 'make clean'**
+
+ When you will make changes to the Arrow C++ part of the code, also
Review comment:
```suggestion
If you make changes to the Arrow C++ part of the code, also
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12401:
URL: https://github.com/apache/arrow/pull/12401#issuecomment-1036140854
https://issues.apache.org/jira/browse/ARROW-15352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12401:
URL: https://github.com/apache/arrow/pull/12401#discussion_r807213427
##########
File path: docs/source/developers/guide/step_by_step/building.rst
##########
@@ -155,6 +155,24 @@ Building other Arrow libraries
`R developer docs <https://arrow.apache.org/docs/r/articles/developing.html>`_.
+ **Reinstalling R package and running 'make clean'**
+
+ If you make changes to the Arrow C++ part of the code, also
+ called libarrow, you will need to:
+
+ #. reinstall libarrow,
+ #. run ``make clean``,
+ #. reinstall the R package.
+
+ The ``make clean`` function is defined in ``r/Makefile`` and will
+ remove any cached object code in the ``r/src/`` directory, insuring
Review comment:
```suggestion
remove any cached object code in the ``r/src/`` directory, ensuring
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12401:
URL: https://github.com/apache/arrow/pull/12401#issuecomment-1040680555
Benchmark runs are scheduled for baseline = cca3800bd95c4476f695cccf2bf9f39abacf4bf3 and contender = 3873f632952370688bfd087e0624f96f3d5b5b56. 3873f632952370688bfd087e0624f96f3d5b5b56 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/56547056e4004c21a8e0a426e97d5187...f5e63b7eeca64a128948fde8ec1ae219/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fe240ea54c542d8918963d4704e702d...7cd1214fd23a4ab9adca085a645cd0ec/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6b3eb5d148714c0e86ce9d85df3558d4...09cbe88987e747aab2a459558aeb55d3/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d19cb70b0fde4c21bc02b1120755ded2...c55efbfdbea345309beec7ada00254d3/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12401:
URL: https://github.com/apache/arrow/pull/12401#discussion_r804706379
##########
File path: docs/source/developers/guide/step_by_step/building.rst
##########
@@ -155,6 +155,22 @@ Building other Arrow libraries
`R developer docs <https://arrow.apache.org/docs/r/articles/developing.html>`_.
+ **Reinstalling R package and running 'make clean'**
+
+ When you will make changes to the Arrow C++ part of the code, also
+ called libarrow, you will need to:
+
+ #. reinstall libarrow
+ #. run ``make clean`` or ``git clean -fdx .``
Review comment:
``make clean`` and ``git clean -fdx .`` do totally different things to each other so I don't think the phrasing is quite right here. I've never run ``git clean -fdx .`` while doing dev work (it could be useful, but isn't essential given I just had to google what it was)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic closed pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean
Posted by GitBox <gi...@apache.org>.
thisisnic closed pull request #12401:
URL: https://github.com/apache/arrow/pull/12401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12401:
URL: https://github.com/apache/arrow/pull/12401#issuecomment-1040680555
Benchmark runs are scheduled for baseline = cca3800bd95c4476f695cccf2bf9f39abacf4bf3 and contender = 3873f632952370688bfd087e0624f96f3d5b5b56. 3873f632952370688bfd087e0624f96f3d5b5b56 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/56547056e4004c21a8e0a426e97d5187...f5e63b7eeca64a128948fde8ec1ae219/)
[Finished :arrow_down:0.09% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fe240ea54c542d8918963d4704e702d...7cd1214fd23a4ab9adca085a645cd0ec/)
[Failed :arrow_down:0.71% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6b3eb5d148714c0e86ce9d85df3558d4...09cbe88987e747aab2a459558aeb55d3/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d19cb70b0fde4c21bc02b1120755ded2...c55efbfdbea345309beec7ada00254d3/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12401:
URL: https://github.com/apache/arrow/pull/12401#issuecomment-1040680555
Benchmark runs are scheduled for baseline = cca3800bd95c4476f695cccf2bf9f39abacf4bf3 and contender = 3873f632952370688bfd087e0624f96f3d5b5b56. 3873f632952370688bfd087e0624f96f3d5b5b56 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/56547056e4004c21a8e0a426e97d5187...f5e63b7eeca64a128948fde8ec1ae219/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3fe240ea54c542d8918963d4704e702d...7cd1214fd23a4ab9adca085a645cd0ec/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6b3eb5d148714c0e86ce9d85df3558d4...09cbe88987e747aab2a459558aeb55d3/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d19cb70b0fde4c21bc02b1120755ded2...c55efbfdbea345309beec7ada00254d3/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12401: ARROW-15352: [Doc][Guide] R package and make clean
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12401:
URL: https://github.com/apache/arrow/pull/12401#discussion_r804707466
##########
File path: docs/source/developers/guide/step_by_step/building.rst
##########
@@ -155,6 +155,22 @@ Building other Arrow libraries
`R developer docs <https://arrow.apache.org/docs/r/articles/developing.html>`_.
+ **Reinstalling R package and running 'make clean'**
+
+ When you will make changes to the Arrow C++ part of the code, also
+ called libarrow, you will need to:
+
+ #. reinstall libarrow
+ #. run ``make clean`` or ``git clean -fdx .``
+ #. reinstall the R package
+
+ ``make clean`` is a part of the ``r/Makefile`` added to help with some
+ common tasks from the command line (e.g. ``make test``, ``make doc``,
+ ``make clean``, etc.).
Review comment:
I might rephrase this, as on a first read I misread it as meaning that `make clean` runs `make test` etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org