You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Bhushan Mandhani (JIRA)" <ji...@apache.org> on 2012/10/27 00:53:13 UTC

[jira] [Created] (HIVE-3626) RetryingHMSHandler should wrap JDOException inside MetaException

Bhushan Mandhani created HIVE-3626:
--------------------------------------

             Summary: RetryingHMSHandler should wrap JDOException inside MetaException
                 Key: HIVE-3626
                 URL: https://issues.apache.org/jira/browse/HIVE-3626
             Project: Hive
          Issue Type: Improvement
          Components: Metastore
            Reporter: Bhushan Mandhani
            Assignee: Bhushan Mandhani
            Priority: Minor


RetryingHMSHandler catches and retries for JDOExceptions. If retry limit is exceeded, it throws the caught JDOException. Instead it should wrap this up in a MetaException. That way the error message and stack trace can be successfully communicated back to the Hive Client by the Thrift host and the client can show better error messages and log messages. Otherwise, everything appears as a TException with no further debugging info. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3626) RetryingHMSHandler should wrap JDOException inside MetaException

Posted by "Bhushan Mandhani (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485292#comment-13485292 ] 

Bhushan Mandhani commented on HIVE-3626:
----------------------------------------

Diff at https://reviews.facebook.net/D6255
                
> RetryingHMSHandler should wrap JDOException inside MetaException
> ----------------------------------------------------------------
>
>                 Key: HIVE-3626
>                 URL: https://issues.apache.org/jira/browse/HIVE-3626
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Bhushan Mandhani
>            Assignee: Bhushan Mandhani
>            Priority: Minor
>
> RetryingHMSHandler catches and retries for JDOExceptions. If retry limit is exceeded, it throws the caught JDOException. Instead it should wrap this up in a MetaException. That way the error message and stack trace can be successfully communicated back to the Hive Client by the Thrift host and the client can show better error messages and log messages. Otherwise, everything appears as a TException with no further debugging info. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3626) RetryingHMSHandler should wrap JDOException inside MetaException

Posted by "Bhushan Mandhani (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bhushan Mandhani updated HIVE-3626:
-----------------------------------

    Attachment: HIVE-3626.1.patch.txt
    
> RetryingHMSHandler should wrap JDOException inside MetaException
> ----------------------------------------------------------------
>
>                 Key: HIVE-3626
>                 URL: https://issues.apache.org/jira/browse/HIVE-3626
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Bhushan Mandhani
>            Assignee: Bhushan Mandhani
>            Priority: Minor
>         Attachments: HIVE-3626.1.patch.txt
>
>
> RetryingHMSHandler catches and retries for JDOExceptions. If retry limit is exceeded, it throws the caught JDOException. Instead it should wrap this up in a MetaException. That way the error message and stack trace can be successfully communicated back to the Hive Client by the Thrift host and the client can show better error messages and log messages. Otherwise, everything appears as a TException with no further debugging info. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3626) RetryingHMSHandler should wrap JDOException inside MetaException

Posted by "Bhushan Mandhani (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bhushan Mandhani updated HIVE-3626:
-----------------------------------

    Status: Patch Available  (was: Open)
    
> RetryingHMSHandler should wrap JDOException inside MetaException
> ----------------------------------------------------------------
>
>                 Key: HIVE-3626
>                 URL: https://issues.apache.org/jira/browse/HIVE-3626
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Bhushan Mandhani
>            Assignee: Bhushan Mandhani
>            Priority: Minor
>
> RetryingHMSHandler catches and retries for JDOExceptions. If retry limit is exceeded, it throws the caught JDOException. Instead it should wrap this up in a MetaException. That way the error message and stack trace can be successfully communicated back to the Hive Client by the Thrift host and the client can show better error messages and log messages. Otherwise, everything appears as a TException with no further debugging info. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3626) RetryingHMSHandler should wrap JDOException inside MetaException

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496279#comment-13496279 ] 

Ashutosh Chauhan commented on HIVE-3626:
----------------------------------------

+1 Bhushan, for completeness can you also upload patch here on jira.
                
> RetryingHMSHandler should wrap JDOException inside MetaException
> ----------------------------------------------------------------
>
>                 Key: HIVE-3626
>                 URL: https://issues.apache.org/jira/browse/HIVE-3626
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Bhushan Mandhani
>            Assignee: Bhushan Mandhani
>            Priority: Minor
>
> RetryingHMSHandler catches and retries for JDOExceptions. If retry limit is exceeded, it throws the caught JDOException. Instead it should wrap this up in a MetaException. That way the error message and stack trace can be successfully communicated back to the Hive Client by the Thrift host and the client can show better error messages and log messages. Otherwise, everything appears as a TException with no further debugging info. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HIVE-3626) RetryingHMSHandler should wrap JDOException inside MetaException

Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashutosh Chauhan updated HIVE-3626:
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.10.0
           Status: Resolved  (was: Patch Available)

Committed to trunk. Thanks, Bhushan!
                
> RetryingHMSHandler should wrap JDOException inside MetaException
> ----------------------------------------------------------------
>
>                 Key: HIVE-3626
>                 URL: https://issues.apache.org/jira/browse/HIVE-3626
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Bhushan Mandhani
>            Assignee: Bhushan Mandhani
>            Priority: Minor
>             Fix For: 0.10.0
>
>         Attachments: HIVE-3626.1.patch.txt
>
>
> RetryingHMSHandler catches and retries for JDOExceptions. If retry limit is exceeded, it throws the caught JDOException. Instead it should wrap this up in a MetaException. That way the error message and stack trace can be successfully communicated back to the Hive Client by the Thrift host and the client can show better error messages and log messages. Otherwise, everything appears as a TException with no further debugging info. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HIVE-3626) RetryingHMSHandler should wrap JDOException inside MetaException

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497119#comment-13497119 ] 

Hudson commented on HIVE-3626:
------------------------------

Integrated in Hive-trunk-h0.21 #1795 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1795/])
    HIVE-3626 : RetryingHMSHandler should wrap JDOException inside MetaException (Bhushan Mandhani via Ashutosh Chauhan) (Revision 1409068)

     Result = FAILURE
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409068
Files : 
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java

                
> RetryingHMSHandler should wrap JDOException inside MetaException
> ----------------------------------------------------------------
>
>                 Key: HIVE-3626
>                 URL: https://issues.apache.org/jira/browse/HIVE-3626
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Bhushan Mandhani
>            Assignee: Bhushan Mandhani
>            Priority: Minor
>             Fix For: 0.10.0
>
>         Attachments: HIVE-3626.1.patch.txt
>
>
> RetryingHMSHandler catches and retries for JDOExceptions. If retry limit is exceeded, it throws the caught JDOException. Instead it should wrap this up in a MetaException. That way the error message and stack trace can be successfully communicated back to the Hive Client by the Thrift host and the client can show better error messages and log messages. Otherwise, everything appears as a TException with no further debugging info. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira