You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by js...@apache.org on 2004/02/09 19:28:15 UTC
cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog LogFilter.java
jsalvata 2004/02/09 10:28:15
Modified: src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog
LogFilter.java
Log:
Making thread-safe by using READ_ONLY_MASK when compiling regexps.
Revision Changes Path
1.6 +1 -1 jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/LogFilter.java
Index: LogFilter.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/LogFilter.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- LogFilter.java 14 Dec 2003 01:35:10 -0000 1.5
+++ LogFilter.java 9 Feb 2004 18:28:15 -0000 1.6
@@ -537,7 +537,7 @@
try
{
Perl5Compiler comp = new Perl5Compiler();
- return comp.compile(pattern);
+ return comp.compile(pattern, Perl5Compiler.READ_ONLY_MASK);
}
catch (Exception exception)
{
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog LogFilter.java
Posted by peter lin <jm...@yahoo.com>.
that seems fine to me :)
no seems to be using the accesslog sampler anyways. Plus, the filter is there, but the GUI doesn't provide a way to enter the filter, so a user would have to harcode it in their own generator/parser.
I couldn't decide how to hook the filter into the sampler, so the implementation of the filter is complete, but has no GUI.
peter
Jordi Salvat i Alabart <js...@atg.com> wrote:
Hi Peter,
I'm not 100% sure these regexps can be used concurrently, since they are
'owned' by each filter, so as far as filters are not reused by different
threads, we should be safe. I preferred to fix it anyway since the
performance penalty incurred is, as fas as I know, very small -- and, as
you know, this bug is very harmful for users and very difficult to diagnose.
Drop me a word if you're certain it's not necessary and I'll roll back
the change.
--
Salut,
Jordi.
jsalvata@apache.org wrote:
> jsalvata 2004/02/09 10:28:15
>
> Modified: src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog
> LogFilter.java
> Log:
> Making thread-safe by using READ_ONLY_MASK when compiling regexps.
>
> Revision Changes Path
> 1.6 +1 -1 jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/LogFilter.java
>
> Index: LogFilter.java
> ===================================================================
> RCS file: /home/cvs/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/LogFilter.java,v
> retrieving revision 1.5
> retrieving revision 1.6
> diff -u -r1.5 -r1.6
> --- LogFilter.java 14 Dec 2003 01:35:10 -0000 1.5
> +++ LogFilter.java 9 Feb 2004 18:28:15 -0000 1.6
> @@ -537,7 +537,7 @@
> try
> {
> Perl5Compiler comp = new Perl5Compiler();
> - return comp.compile(pattern);
> + return comp.compile(pattern, Perl5Compiler.READ_ONLY_MASK);
> }
> catch (Exception exception)
> {
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
---------------------------------
Do you Yahoo!?
Yahoo! Finance: Get your refund fast by filing online
Re: cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog
LogFilter.java
Posted by Jordi Salvat i Alabart <js...@atg.com>.
Hi Peter,
I'm not 100% sure these regexps can be used concurrently, since they are
'owned' by each filter, so as far as filters are not reused by different
threads, we should be safe. I preferred to fix it anyway since the
performance penalty incurred is, as fas as I know, very small -- and, as
you know, this bug is very harmful for users and very difficult to diagnose.
Drop me a word if you're certain it's not necessary and I'll roll back
the change.
--
Salut,
Jordi.
jsalvata@apache.org wrote:
> jsalvata 2004/02/09 10:28:15
>
> Modified: src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog
> LogFilter.java
> Log:
> Making thread-safe by using READ_ONLY_MASK when compiling regexps.
>
> Revision Changes Path
> 1.6 +1 -1 jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/LogFilter.java
>
> Index: LogFilter.java
> ===================================================================
> RCS file: /home/cvs/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/LogFilter.java,v
> retrieving revision 1.5
> retrieving revision 1.6
> diff -u -r1.5 -r1.6
> --- LogFilter.java 14 Dec 2003 01:35:10 -0000 1.5
> +++ LogFilter.java 9 Feb 2004 18:28:15 -0000 1.6
> @@ -537,7 +537,7 @@
> try
> {
> Perl5Compiler comp = new Perl5Compiler();
> - return comp.compile(pattern);
> + return comp.compile(pattern, Perl5Compiler.READ_ONLY_MASK);
> }
> catch (Exception exception)
> {
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org