You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/01 01:21:31 UTC
[GitHub] [incubator-druid] vogievetsky opened a new pull request #7389:
Popovers are no longer inline
vogievetsky opened a new pull request #7389: Popovers are no longer inline
URL: https://github.com/apache/incubator-druid/pull/7389
Figured out the container CSS needed to make the portals work and was able to make the Popovers (and dialogs) use portals instead of being `inline`.
Why is this important? Well check this out:
Before:
After:
Notice how the backdrop in the "before" image only covers the header. This is an annoying visual artifact. Using a portal instead of declaring `inline` magically fixes it.
Also made misc usability fixes like having the spec dialog not start empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org