You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/02/23 18:53:12 UTC
[jira] [Commented] (TS-3347) make ink_assert a no-op in release
builds
[ https://issues.apache.org/jira/browse/TS-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333572#comment-14333572 ]
ASF subversion and git services commented on TS-3347:
-----------------------------------------------------
Commit 0143ca195270fb17f003b05cf457570aa5a807ba in trafficserver's branch refs/heads/master from [~jpeach@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=0143ca1 ]
TS-3347: fix assertions that have side-effects
Coverity CID #1242347
Coverity CID #1242346
Coverity CID #1242344
Coverity CID #1242343
Coverity CID #1242341
Coverity CID #1242342
> make ink_assert a no-op in release builds
> -----------------------------------------
>
> Key: TS-3347
> URL: https://issues.apache.org/jira/browse/TS-3347
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Reporter: Sudheer Vinukonda
> Fix For: 5.3.0
>
>
> ink_assert() is expected to be enabled only in DEBUG builds. However, the current definition of ink_assert() for non-DEBUG (release) builds, still evaluates the expression passed to it, which seems totally unnecessary. Opening this jira to make ink_assert() a complete no-op for non-DEBUG release builds. Along with the change of definition, need to scan the entire TS code to fix the code that relies on the expression evaluated in the ink_assert() accordingly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)