You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/19 17:33:23 UTC

[GitHub] [arrow-rs] alamb commented on a diff in pull request #3567: Implement `std::error::Error::source` for `ArrowError` and `FlightError`

alamb commented on code in PR #3567:
URL: https://github.com/apache/arrow-rs/pull/3567#discussion_r1081602031


##########
arrow-flight/src/error.rs:
##########
@@ -52,7 +54,15 @@ impl std::fmt::Display for FlightError {
     }
 }
 
-impl std::error::Error for FlightError {}
+impl Error for FlightError {

Review Comment:
   this is the change (and the same for ArrowError) -- the rest of the PR is tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org